From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mackerras <paulus@samba.org>, Helge Deller <deller@gmx.de>,
sparclinux@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org,
Jesper Nilsson <jesper.nilsson@axis.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Hirokazu Takata <takata@linux-m32r.org>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
Matt Turner <mattst88@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Mike Frysinger <vapier@gentoo.org>,
user-mode-linux-devel@lists.sourceforge.net,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jeff Dike <jdike@addtoit.com>,
Chris Metcalf <cmetcalf@tilera.com>,
xen-devel@lists.xensource.com, Mikael Starvik <starvik@axis.com>,
linux-m32r@ml.linux-m32r.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
user-mode-linux-user@lists.sourceforge.net,
uclinux-dist-devel@blackfin.uclinux.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Richard Henderson <rth@twiddle.net>,
Tony Luck <tony.luck@intel.com>,
linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com,
linux-am33-list@redhat.com, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Kyle McMartin <kyle@mcmartin.ca>,
Paul Mundt <lethal@linux-sh.org>,
linux-alpha@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()
Date: Mon, 17 Jan 2011 11:26:37 +0000 [thread overview]
Message-ID: <20110117112637.GA18599@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1295262433.30950.53.camel@laptop>
On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote:
> diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
> index 42aa078..c4a570b 100644
> --- a/arch/alpha/kernel/smp.c
> +++ b/arch/alpha/kernel/smp.c
> @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs)
> case IPI_RESCHEDULE:
> /* Reschedule callback. Everything to be done
> is done by the interrupt return path. */
> + scheduler_ipi();
> break;
>
> case IPI_CALL_FUNC:
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index 9066473..ffde790 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -579,6 +579,7 @@ asmlinkage void __exception do_IPI(struct pt_regs *regs)
> * nothing more to do - eveything is
> * done on the interrupt return path
> */
> + scheduler_ipi();
Maybe remove the comment "everything is done on the interrupt return path"
as with this function call, that is no longer the case.
Looks like the same is true for Alpha as well?
next prev parent reply other threads:[~2011-01-17 11:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 11:07 [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() Peter Zijlstra
2011-01-17 11:26 ` Russell King - ARM Linux [this message]
2011-01-17 11:31 ` Peter Zijlstra
2011-01-17 11:41 ` Peter Zijlstra
2011-01-17 11:57 ` Russell King - ARM Linux
2011-01-17 13:52 ` Chris Metcalf
2011-01-17 13:58 ` Jesper Nilsson
2011-01-17 12:18 ` Martin Schwidefsky
2011-01-17 19:18 ` David Daney
2011-01-17 19:49 ` [uclinux-dist-devel] " Mike Frysinger
2011-01-17 20:16 ` Peter Zijlstra
2011-01-17 20:31 ` Benjamin Herrenschmidt
2011-01-17 20:43 ` Peter Zijlstra
2011-02-06 23:26 ` Benjamin Herrenschmidt
2011-02-07 13:54 ` Peter Zijlstra
2011-02-09 6:14 ` Benjamin Herrenschmidt
2011-02-09 9:37 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117112637.GA18599@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jdike@addtoit.com \
--cc=jejb@parisc-linux.org \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jesper.nilsson@axis.com \
--cc=konrad.wilk@oracle.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=virtualization@lists.osdl.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).