From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtagate1.uk.ibm.com (mtagate1.uk.ibm.com [194.196.100.161]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mtagate1.uk.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 209A5B70A3 for ; Mon, 17 Jan 2011 23:18:39 +1100 (EST) Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p0HCITnI005417 for ; Mon, 17 Jan 2011 12:18:29 GMT Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0HCIWAx1089540 for ; Mon, 17 Jan 2011 12:18:32 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0HCIQ9s006694 for ; Mon, 17 Jan 2011 05:18:29 -0700 Date: Mon, 17 Jan 2011 13:18:23 +0100 From: Martin Schwidefsky To: Peter Zijlstra Subject: Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule() Message-ID: <20110117131823.410e515c@mschwide.boeblingen.de.ibm.com> In-Reply-To: <1295262433.30950.53.camel@laptop> References: <1295262433.30950.53.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, "H. Peter Anvin" , Heiko Carstens , Paul Mackerras , Helge Deller , sparclinux@vger.kernel.org, Linux-Arch , linux-s390@vger.kernel.org, Jesper Nilsson , Jeremy Fitzhardinge , Russell King , Hirokazu Takata , x86@kernel.org, "James E.J. Bottomley" , virtualization@lists.osdl.org, Ingo Molnar , Matt Turner , Fenghua Yu , Mike Frysinger , user-mode-linux-devel@lists.sourceforge.net, Konrad Rzeszutek Wilk , Jeff Dike , Chris Metcalf , xen-devel@lists.xensource.com, Mikael Starvik , linux-m32r@ml.linux-m32r.org, Ivan Kokshaysky , user-mode-linux-user@lists.sourceforge.net, uclinux-dist-devel@blackfin.uclinux.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Richard Henderson , Tony Luck , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-am33-list@redhat.com, linux-kernel@vger.kernel.org, Ralf Baechle , Kyle McMartin , Paul Mundt , linux-alpha@vger.kernel.org, linux390@de.ibm.com, Koichi Yasutake , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 17 Jan 2011 12:07:13 +0100 Peter Zijlstra wrote: > I visited existing smp_send_reschedule() implementations and tried to > add a call to scheduler_ipi() in their handler part, but esp. for MIPS > I'm not quite sure I actually got all of them. > > diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c > index 94cf510..61789e8 100644 > --- a/arch/s390/kernel/smp.c > +++ b/arch/s390/kernel/smp.c > @@ -163,12 +163,12 @@ static void do_ext_call_interrupt(unsigned int ext_int_code, > > /* > * handle bit signal external calls > - * > - * For the ec_schedule signal we have to do nothing. All the work > - * is done automatically when we return from the interrupt. > */ > bits = xchg(&S390_lowcore.ext_call_fast, 0); > > + if (test_bit(ec_schedule, &bits)) > + scheduler_ipi(); > + > if (test_bit(ec_call_function, &bits)) > generic_smp_call_function_interrupt(); > s390 bits are fine. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.