From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 20 Jan 2011 12:35:07 -0800 From: Andrew Morton To: torbenh Subject: Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock() Message-Id: <20110120123507.ac89c034.akpm@linux-foundation.org> In-Reply-To: <20110120165502.GA10832@siel.b> References: <1295539104-13210-1-git-send-email-torbenh@gmx.de> <20110120163448.GA30588@suse.de> <20110120165502.GA10832@siel.b> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: xen-devel@lists.xensource.com, Kees Cook , linux-fbdev@vger.kernel.org, Mark Brown , James Hogan , David Airlie , Jesse Barnes , James Morris , Paul Mackerras , linux-parisc@vger.kernel.org, Magnus Damm , Jiri Slaby , Dan Williams , devel@driverdev.osuosl.org, Guy Martin , Kuninori Morimoto , Jeremy Fitzhardinge , Russell King , Thomas Gleixner , Wu Zhangjin , Florian Tobias Schandinat , Lionel Debroux , Helge Deller , Kay Sievers , "James E.J. Bottomley" , Kevin Hilman , Tony Lindgren , cbe-oss-dev@lists.ozlabs.org, Ben Skeggs , Ingo Molnar , Daniel Vetter , Dave Airlie , David Brown , Francisco Jerez , virtualization@lists.linux-foundation.org, Namhyung Kim , Marcin Slusarz , Alberto Panizzo , Rusty Russell , Ondrej Zary , Denys Vlasenko , Antonino Daplas , Konrad Rzeszutek Wilk , Abhijeet Dharmapurikar , Andres Salomon , Werner Fink , Phil Edworthy , linux-geode@lists.infradead.org, Alex Deucher , Jerome Glisse , Lars-Peter Clausen , Alexey Dobriyan , Daniel Mack , Nicolas Pitre , Thomas Gleixner , linux-omap@vger.kernel.org, Ondrej Zajicek , linux-arm-kernel@lists.infradead.org, Liam Girdwood , Daniel Walker , Linus Walleij , Caglar Akyuz , Geoff Levand , Jiri Kosina , dri-devel@lists.freedesktop.org, Greg KH , linux-kernel@vger.kernel.org, Ralf Baechle , Guennadi Liakhovetski , Kyle McMartin , Jean Delvare , Paul Mundt , Arnd Bergmann , Takashi Iwai , Jason Wessel , Tejun Heo , Julia Lawall , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Marcin =?UTF-8?Q?Ko=C5=9Bcielnicki?= List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 20 Jan 2011 17:55:02 +0100 torbenh wrote: > On Thu, Jan 20, 2011 at 08:34:48AM -0800, Greg KH wrote: > > On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote: > > > the -rt patches change the console_semaphore to console_mutex. > > > so a quite large chunk of the patches changes all > > > acquire/release_console_sem() to acquire/release_console_mutex() > > > > Why not just change the functionality of the existing function to be a > > mutex in the rt patches, instead of having to rename it everywhere? > > i hope that Thomas already did this in his upcoming -rt series. > > > > > > this commit makes things use more neutral function names > > > which dont make implications about the underlying lock. > > > > > > the only real change is the return value of console_trylock > > > which is inverted from try_acquire_console_sem() > > > > > > Signed-off-by: Torben Hohn > > > CC: Thomas Gleixner > > > > I don't mind this rename, but is it really going to help anything out? > > What's the odds of the -rt portion of this patch ever making it to > > mainline? > > the -rt portion only changes the semaphore to a mutex. > since the console_sem is used with mutex semantics, i dont see any > reason, not to merge that portion too. > > i am just trying to shrink the -rt patch to make it more maintanable :) > Yeah, I think it's a better name and if we can indeed switch that semaphore to a mutex then that's a good thing to do.