From: Dave Jones <davej@redhat.com>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver
Date: Tue, 8 Feb 2011 12:29:11 -0500 [thread overview]
Message-ID: <20110208172910.GA32742@redhat.com> (raw)
In-Reply-To: <20110208172046.GB10125@ovro.caltech.edu>
On Tue, Feb 08, 2011 at 09:20:46AM -0800, Ira W. Snyder wrote:
> > > +static DEVICE_ATTR(enable, S_IWUGO | S_IRUGO, data_en_show, data_en_set);
> >
> > Are all of these really needed or most of them are for debug?
> >
>
> Most are for debugging. They have proved useful a few times in
> production to track down bugs.
File mode should probably not be world writable.
(checkpatch.pl should warn you about this now btw)
Dave
next prev parent reply other threads:[~2011-02-08 17:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 23:23 [PATCH RFCv4 0/2] CARMA Board Support Ira W. Snyder
2011-02-07 23:23 ` [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver Ira W. Snyder
2011-02-08 7:33 ` Dmitry Torokhov
2011-02-08 17:20 ` Ira W. Snyder
2011-02-08 17:29 ` Dave Jones [this message]
2011-02-08 17:50 ` Dmitry Torokhov
2011-02-08 19:11 ` Ira W. Snyder
2011-02-08 19:33 ` Dmitry Torokhov
2011-02-09 16:30 ` David Laight
2011-02-09 17:03 ` Ira W. Snyder
2011-02-07 23:23 ` [PATCH 2/2] misc: add CARMA DATA-FPGA Programmer support Ira W. Snyder
-- strict thread matches above, loose matches on Subject: below --
2011-02-08 23:37 [PATCH RFCv5 0/2] CARMA Board Support Ira W. Snyder
2011-02-08 23:37 ` [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver Ira W. Snyder
2011-02-09 8:33 ` Dmitry Torokhov
2011-02-09 17:35 ` Ira W. Snyder
2011-02-09 18:27 ` Dmitry Torokhov
2011-02-09 23:35 ` Ira W. Snyder
2011-02-09 23:42 ` Dmitry Torokhov
2011-02-10 0:10 ` Ira W. Snyder
2011-02-10 0:39 ` Dmitry Torokhov
2011-02-10 9:02 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208172910.GA32742@redhat.com \
--to=davej@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).