From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
akpm@linux-foundation.org, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden
Date: Wed, 9 Mar 2011 20:20:46 +0800 [thread overview]
Message-ID: <20110309122046.GC16951@cr0.redhat.com> (raw)
In-Reply-To: <4D771EE6.5050404@linux.vnet.ibm.com>
On Wed, Mar 09, 2011 at 12:02:06PM +0530, Mahesh Jagannath Salgaonkar wrote:
>On 08/25/2010 06:07 AM, Eric W. Biederman wrote:
>> Anton Blanchard <anton@samba.org> writes:
>>
>>> On ppc64 the crashkernel region almost always overlaps an area of firmware.
>>> This works fine except when using the sysfs interface to reduce the kdump
>>> region. If we free the firmware area we are guaranteed to crash.
>>
>> That is ppc64 bug. firmware should not be in the reserved region. Any
>> random kernel like thing can be put in to that region at any valid
>> address and the fact that shrinking the region frees your firmware means
>> that using that region could also stomp your firmware (which I assume
>> would be a bad thing).
>The issue only happens while shrinking the region using sysfs interface.
>We already have checks in kexec for not to stomp over on the firmware
>overlap area while loading capture kernel. Currently we do a top-down
>allocation for the firmware region which means it sits at the top of the
>RMO, right in the middle of the crashdump region. We can not move the
>crashkernel region beyond firmware region because kernel needs its some
>of memory in RMO region.
The crashkernel region is specified via kernel cmdline, so why
not just drop a failure when it overlaps with RMO region?
Am I missing something?
Thanks.
next prev parent reply other threads:[~2011-03-09 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 0:22 [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden Anton Blanchard
2010-08-25 0:23 ` [PATCH 2/2] powerpc: kdump: Override crash_free_reserved_phys_range to avoid freeing RTAS Anton Blanchard
2010-08-25 0:37 ` [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden Eric W. Biederman
2011-03-09 6:32 ` Mahesh Jagannath Salgaonkar
2011-03-09 12:20 ` Américo Wang [this message]
2011-03-09 12:46 ` Anton Blanchard
2011-03-09 14:21 ` Américo Wang
2011-03-14 18:13 ` Mahesh J Salgaonkar
2011-03-15 7:52 ` Américo Wang
2011-03-15 16:52 ` Mahesh J Salgaonkar
2011-03-21 3:10 ` WANG Cong
2011-03-24 4:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309122046.GC16951@cr0.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).