From: Stephen Wilson <wilsons@start.ca>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-s390@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org, x86@kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, Thomas Gleixner <tglx@linutronix.de>,
Michel Lespinasse <walken@google.com>,
linuxppc-dev@lists.ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct II
Date: Thu, 10 Mar 2011 11:54:14 -0500 [thread overview]
Message-ID: <20110310165414.GA6431@fibrous.localdomain> (raw)
In-Reply-To: <20110310163809.GA20675@alboin.amr.corp.intel.com>
On Thu, Mar 10, 2011 at 08:38:09AM -0800, Andi Kleen wrote:
> On Thu, Mar 10, 2011 at 08:00:32AM -0800, Andi Kleen wrote:
> > On Tue, Mar 08, 2011 at 07:31:56PM -0500, Stephen Wilson wrote:
> > > The only architecture this change impacts in any significant way is x86_64.
> > > The principle change on that architecture is to mirror TIF_IA32 via
> > > a new flag in mm_context_t.
> >
> > The problem is -- you're adding a likely cache miss on mm_struct for
> > every 32bit compat syscall now, even if they don't need mm_struct
> > currently (and a lot of them do not) Unless there's a very good
> > justification to make up for this performance issue elsewhere
> > (including numbers) this seems like a bad idea.
>
> Hmm I see you're only setting it on exec time actually on rereading
> the patches. I thought you were changing TS_COMPAT which is in
> the syscall path.
>
> Never mind. I have no problems with doing such a change on exec
> time.
OK. Great! Does this mean I have your ACK'ed by or reviewed by?
Thanks for taking a look!
--
steve
next prev parent reply other threads:[~2011-03-10 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 0:31 [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct Stephen Wilson
2011-03-09 0:31 ` [PATCH 1/5] x86: add context tag to mark mm when running a task in 32-bit compatibility mode Stephen Wilson
2011-03-09 0:31 ` [PATCH 2/5] x86: mark associated mm when running a task in 32 bit " Stephen Wilson
2011-03-09 0:31 ` [PATCH 3/5] mm: arch: make get_gate_vma take an mm_struct instead of a task_struct Stephen Wilson
2011-03-09 0:32 ` [PATCH 4/5] mm: arch: make in_gate_area " Stephen Wilson
2011-03-09 0:32 ` [PATCH 5/5] mm: arch: rename in_gate_area_no_task to in_gate_area_no_mm Stephen Wilson
2011-03-09 13:09 ` [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct Michel Lespinasse
2011-03-09 14:14 ` Stephen Wilson
2011-03-10 16:00 ` Andi Kleen
2011-03-10 16:38 ` [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct II Andi Kleen
2011-03-10 16:54 ` Stephen Wilson [this message]
2011-03-10 17:03 ` Andi Kleen
2011-03-10 17:22 ` H. Peter Anvin
2011-03-10 16:40 ` [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct Stephen Wilson
2011-03-10 17:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310165414.GA6431@fibrous.localdomain \
--to=wilsons@start.ca \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).