From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glikely@secretlab.ca>
Received: from mail-iy0-f179.google.com (mail-iy0-f179.google.com
	[209.85.210.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by ozlabs.org (Postfix) with ESMTPS id 0DD47B6FDA
	for <linuxppc-dev@lists.ozlabs.org>;
	Sat, 19 Mar 2011 02:51:07 +1100 (EST)
Received: by iym7 with SMTP id 7so4304057iym.38
	for <linuxppc-dev@lists.ozlabs.org>;
	Fri, 18 Mar 2011 08:51:05 -0700 (PDT)
Sender: Grant Likely <glikely@secretlab.ca>
Date: Fri, 18 Mar 2011 09:51:02 -0600
From: Grant Likely <grant.likely@secretlab.ca>
To: Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 1/1] SPI: dw_spi, fix PPC build
Message-ID: <20110318155102.GA22790@angua.secretlab.ca>
References: <1300441277-23961-1-git-send-email-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <1300441277-23961-1-git-send-email-jslaby@suse.cz>
Cc: dbrownell@users.sourceforge.net, jirislaby@gmail.com,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	spi-devel-general@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On Fri, Mar 18, 2011 at 10:41:17AM +0100, Jiri Slaby wrote:
> Currently, build on PPC dies with:
> In file included from drivers/spi/dw_spi_mmio.c:16:
> include/linux/spi/dw_spi.h:147: error: field ‘tx_sgl’ has incomplete type
> include/linux/spi/dw_spi.h:149: error: field ‘rx_sgl’ has incomplete type
> 
> Add linux/scatterlist.h include to dw_spi.h, because we need to know
> the contents of the structure.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>

Applied, thanks.

g.

> ---
>  include/linux/spi/dw_spi.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/spi/dw_spi.h b/include/linux/spi/dw_spi.h
> index 6cd10f6..fb0bce5 100644
> --- a/include/linux/spi/dw_spi.h
> +++ b/include/linux/spi/dw_spi.h
> @@ -2,6 +2,7 @@
>  #define DW_SPI_HEADER_H
>  
>  #include <linux/io.h>
> +#include <linux/scatterlist.h>
>  
>  /* Bit fields in CTRLR0 */
>  #define SPI_DFS_OFFSET			0
> -- 
> 1.7.4.1
> 
>