From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] KVM: PPC: e500: SPE switch between guest and host
Date: Tue, 29 Mar 2011 12:25:14 -0500 [thread overview]
Message-ID: <20110329122514.32c767ca@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <6785E5D0-DEE9-4661-88A4-B35A99DB3C66@suse.de>
On Tue, 29 Mar 2011 11:47:51 +0200
Alexander Graf <agraf@suse.de> wrote:
> On 28.03.2011, at 21:25, Scott Wood wrote:
>
> > @@ -344,10 +345,19 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
> > r = RESUME_GUEST;
> > break;
> >
> > - case BOOKE_INTERRUPT_SPE_UNAVAIL:
> > - kvmppc_booke_queue_irqprio(vcpu, BOOKE_IRQPRIO_SPE_UNAVAIL);
> > +#ifdef CONFIG_SPE
> > + case BOOKE_INTERRUPT_SPE_UNAVAIL: {
>
> This means that on non-SPE enabled host kernels you'll get a KVM fatal error when the guest triggers SPE_UNAVAIL, as the exit simply isn't handled and triggers:
>
> default:
> printk(KERN_EMERG "exit_nr %d\n", exit_nr);
> BUG();
Right, thanks for spotting -- will have it send an illegal instruction trap
to the guest in that case.
-Scott
prev parent reply other threads:[~2011-03-29 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 19:24 [PATCH 1/4] powerpc/e500v2: Save SPEFCSR in flush_spe_to_thread() Scott Wood
2011-03-28 19:25 ` [PATCH 2/4] KVM: PPC: booke: Wrap __kvmppc_vcpu_run() Scott Wood
2011-03-29 9:31 ` Alexander Graf
2011-03-29 9:36 ` Liu Yu-B13201
2011-03-29 9:48 ` Alexander Graf
2011-03-28 19:25 ` [PATCH 3/4] KVM: PPC: e500: Introduce msr_block for e500v2 Scott Wood
2011-03-29 9:37 ` Alexander Graf
2011-03-29 17:26 ` Scott Wood
2011-03-28 19:25 ` [PATCH 4/4] KVM: PPC: e500: SPE switch between guest and host Scott Wood
2011-03-29 9:47 ` Alexander Graf
2011-03-29 17:25 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329122514.32c767ca@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).