From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, bluesmoke-devel@lists.sourceforge.net,
dougthompson@xmission.com
Subject: Re: [PATCH] edac/mpc85xx: Limit setting/clearing of HID1[RFXE] to e500v1/v2 cores
Date: Thu, 31 Mar 2011 15:42:08 -0700 [thread overview]
Message-ID: <20110331224208.GA30426@us.ibm.com> (raw)
In-Reply-To: <1301610194-29971-1-git-send-email-galak@kernel.crashing.org>
On 31.03.2011 [17:23:14 -0500], Kumar Gala wrote:
> Only the e500v1/v2 cores have HID1[RXFE] so we should attempt to set or
> clear this register bit on them. Otherwise we get crashes like:
<snip>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index b123bb3..5aef2ed 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
<snip>
> @@ -1209,10 +1215,15 @@ static void __exit mpc85xx_mc_restore_hid1(void *data)
> static void __exit mpc85xx_mc_exit(void)
> {
> #ifdef CONFIG_FSL_SOC_BOOKE
> - on_each_cpu(mpc85xx_mc_restore_hid1, NULL, 0);
> + u32 pvr = mfspr(SPRN_PVR);
> +
> + if ((PVR_VER(pvr) == PVR_VER_E500V1) ||
> + (PVR_VER(pvr) == PVR_VER_E500V2)) {
> + on_each_cpu(mpc85xx_mc_restore_hid1, NULL, 0);
> + }
> #endif
> #ifdef CONFIG_PCI
> - of_unregister_platform_driver(&mpc85xx_pci_err_driver);
> + of_unregistr_platform_driver(&mpc85xx_pci_err_driver);
Unintended change?
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
next prev parent reply other threads:[~2011-03-31 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 22:23 [PATCH] edac/mpc85xx: Limit setting/clearing of HID1[RFXE] to e500v1/v2 cores Kumar Gala
2011-03-31 22:42 ` Nishanth Aravamudan [this message]
2011-04-01 13:03 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331224208.GA30426@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dougthompson@xmission.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).