From: Felipe Balbi <balbi@ti.com>
To: tmarri@apm.com
Cc: Mark Miesfeld <mmiesfeld@apm.com>,
greg@kroah.com, linux-usb@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Fushen Chen <fchen@apm.com>
Subject: Re: [PATCH v13 07/10] USB/ppc4xx: Add Synopsys DWC OTG PCD function
Date: Mon, 4 Apr 2011 16:54:10 +0300 [thread overview]
Message-ID: <20110404135408.GO2461@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1301872630-2980-1-git-send-email-tmarri@apm.com>
Hi,
On Sun, Apr 03, 2011 at 04:17:10PM -0700, tmarri@apm.com wrote:
> +static const struct usb_gadget_ops dwc_otg_pcd_ops = {
> + .get_frame = dwc_otg_pcd_get_frame,
> + .wakeup = dwc_otg_pcd_wakeup,
> + /* not selfpowered */
will you really have a board running this top operating system which is
Bus powered ? Unless you're forcing all your boards to come with USB
charging I guess you should implement set_selfpowered.
--
balbi
prev parent reply other threads:[~2011-04-04 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 23:17 [PATCH v13 07/10] USB/ppc4xx: Add Synopsys DWC OTG PCD function tmarri
2011-04-04 13:54 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404135408.GO2461@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=fchen@apm.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmiesfeld@apm.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).