[RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[Justin P. Mattock]

The patch below removes an unused config variable found by using a kernel
cleanup script.
Note: I did try to cross compile these but hit erros while doing so..
(gcc is not setup to cross compile) and am unsure if anymore needs to be done.
Please have a look if/when anybody has free time.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: linuxppc-dev@lists.ozlabs.org

---
 arch/powerpc/sysdev/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index 1e0c933..243b6ad 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -18,7 +18,6 @@ obj-$(CONFIG_FSL_PMC)		+= fsl_pmc.o
 obj-$(CONFIG_FSL_LBC)		+= fsl_lbc.o
 obj-$(CONFIG_FSL_GTM)		+= fsl_gtm.o
 obj-$(CONFIG_MPC8xxx_GPIO)	+= mpc8xxx_gpio.o
-obj-$(CONFIG_FSL_85XX_CACHE_SRAM)	+= fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o
 obj-$(CONFIG_SIMPLE_GPIO)	+= simple_gpio.o
 obj-$(CONFIG_FSL_RIO)		+= fsl_rio.o
 obj-$(CONFIG_TSI108_BRIDGE)	+= tsi108_pci.o tsi108_dev.o
-- 
1.7.4.2

[RFC 5/5]arch:powerpc:kernel:Makefile Remove unused config in the Makefile.

[Justin P. Mattock]

The patch below removes an unused config variable found by using a kernel
cleanup script.
Note: I did try to cross compile these but hit erros while doing so..
(gcc is not setup to cross compile) and am unsure if anymore needs to be done.
Please have a look if/when anybody has free time.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org

---
 arch/powerpc/kernel/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 3bb2a3e..4fa0d52 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -75,7 +75,6 @@ obj-$(CONFIG_PPC_FSL_BOOK3E)	+= cpu_setup_fsl_booke.o dbell.o
 obj-$(CONFIG_PPC_BOOK3E_64)	+= dbell.o
 
 extra-y				:= head_$(CONFIG_WORD_SIZE).o
-extra-$(CONFIG_PPC_BOOK3E_32)	:= head_new_booke.o
 extra-$(CONFIG_40x)		:= head_40x.o
 extra-$(CONFIG_44x)		:= head_44x.o
 extra-$(CONFIG_FSL_BOOKE)	:= head_fsl_booke.o
-- 
1.7.4.2

Re: [RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[Scott Wood]

On Tue, 5 Apr 2011 09:58:19 -0700
"Justin P. Mattock" <justinmattock@gmail.com> wrote:

> The patch below removes an unused config variable found by using a kernel
> cleanup script.
> Note: I did try to cross compile these but hit erros while doing so..
> (gcc is not setup to cross compile) and am unsure if anymore needs to be done.
> Please have a look if/when anybody has free time.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: linuxppc-dev@lists.ozlabs.org
> 
> ---
>  arch/powerpc/sysdev/Makefile |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
> index 1e0c933..243b6ad 100644
> --- a/arch/powerpc/sysdev/Makefile
> +++ b/arch/powerpc/sysdev/Makefile
> @@ -18,7 +18,6 @@ obj-$(CONFIG_FSL_PMC)		+= fsl_pmc.o
>  obj-$(CONFIG_FSL_LBC)		+= fsl_lbc.o
>  obj-$(CONFIG_FSL_GTM)		+= fsl_gtm.o
>  obj-$(CONFIG_MPC8xxx_GPIO)	+= mpc8xxx_gpio.o
> -obj-$(CONFIG_FSL_85XX_CACHE_SRAM)	+= fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o
>  obj-$(CONFIG_SIMPLE_GPIO)	+= simple_gpio.o
>  obj-$(CONFIG_FSL_RIO)		+= fsl_rio.o
>  obj-$(CONFIG_TSI108_BRIDGE)	+= tsi108_pci.o tsi108_dev.o

Those files do exist, and aren't pulled in by any other means I can see.
It was introduced by commit 6db92cc9d07db9f713da8554b4bcdfc8e54ad386, whose
changelog says:
	Drivers can do the following in Kconfig to use these APIs "select
FSL_85XX_CACHE_SRAM if MPC85xx"

Now, the absence of such a kconfig option[1] is a problem, but I don't think
outright removal (labelled "trivial cleanup") is appropriate, unless nobody
fixes it after the problem is pointed out.  And if it is removed, the files
should go with it.

-Scott

[1] and of any drivers that select it, though this was added fairly
recently -- perhaps such a driver change is on its way?

Re: [RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[Justin Mattock]

On Tue, Apr 5, 2011 at 11:15 AM, Scott Wood <scottwood@freescale.com> wrote=
:
> On Tue, 5 Apr 2011 09:58:19 -0700
> "Justin P. Mattock" <justinmattock@gmail.com> wrote:
>
>> The patch below removes an unused config variable found by using a kerne=
l
>> cleanup script.
>> Note: I did try to cross compile these but hit erros while doing so..
>> (gcc is not setup to cross compile) and am unsure if anymore needs to be=
 done.
>> Please have a look if/when anybody has free time.
>>
>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> CC: linuxppc-dev@lists.ozlabs.org
>>
>> ---
>> =A0arch/powerpc/sysdev/Makefile | =A0 =A01 -
>> =A01 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
>> index 1e0c933..243b6ad 100644
>> --- a/arch/powerpc/sysdev/Makefile
>> +++ b/arch/powerpc/sysdev/Makefile
>> @@ -18,7 +18,6 @@ obj-$(CONFIG_FSL_PMC) =A0 =A0 =A0 =A0 =A0 =A0 =A0 +=3D=
 fsl_pmc.o
>> =A0obj-$(CONFIG_FSL_LBC) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+=3D fsl_lbc.o
>> =A0obj-$(CONFIG_FSL_GTM) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+=3D fsl_gtm.o
>> =A0obj-$(CONFIG_MPC8xxx_GPIO) =A0 +=3D mpc8xxx_gpio.o
>> -obj-$(CONFIG_FSL_85XX_CACHE_SRAM) =A0 =A0+=3D fsl_85xx_l2ctlr.o fsl_85x=
x_cache_sram.o
>> =A0obj-$(CONFIG_SIMPLE_GPIO) =A0 =A0+=3D simple_gpio.o
>> =A0obj-$(CONFIG_FSL_RIO) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+=3D fsl_rio.o
>> =A0obj-$(CONFIG_TSI108_BRIDGE) =A0+=3D tsi108_pci.o tsi108_dev.o
>
> Those files do exist, and aren't pulled in by any other means I can see.
> It was introduced by commit 6db92cc9d07db9f713da8554b4bcdfc8e54ad386, who=
se
> changelog says:
> =A0 =A0 =A0 =A0Drivers can do the following in Kconfig to use these APIs =
"select
> FSL_85XX_CACHE_SRAM if MPC85xx"
>
> Now, the absence of such a kconfig option[1] is a problem, but I don't th=
ink
> outright removal (labelled "trivial cleanup") is appropriate, unless nobo=
dy
> fixes it after the problem is pointed out. =A0And if it is removed, the f=
iles
> should go with it.
>
> -Scott
>
> [1] and of any drivers that select it, though this was added fairly
> recently -- perhaps such a driver change is on its way?
>
>

ahh.. so the:  fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o is still in use
even though FSL_85XX_CACHE_SRAM is not really used, but really is used!!

but might be wrong with this.

--=20
Justin P. Mattock

Re: [RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[Scott Wood]

On Wed, 6 Apr 2011 08:07:58 -0700
Justin Mattock <justinmattock@gmail.com> wrote:

> ahh.. so the:  fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o is still in use
> even though FSL_85XX_CACHE_SRAM is not really used, but really is used!!
> 
> but might be wrong with this.

More like there are plans to use it, or possibly out-of-tree users.  We
should prod people a bit to submit the driver patches that use this before
we just yank it out.

-Scott

Re: [RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.

[Justin Mattock]

On Wed, Apr 6, 2011 at 9:03 AM, Scott Wood <scottwood@freescale.com> wrote:
> On Wed, 6 Apr 2011 08:07:58 -0700
> Justin Mattock <justinmattock@gmail.com> wrote:
>
>> ahh.. so the: =A0fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o is still in use
>> even though FSL_85XX_CACHE_SRAM is not really used, but really is used!!
>>
>> but might be wrong with this.
>
> More like there are plans to use it, or possibly out-of-tree users. =A0We
> should prod people a bit to submit the driver patches that use this befor=
e
> we just yank it out.
>
> -Scott
>
>

well if this is going to be used for something down the line, then
best leave it in..

--=20
Justin P. Mattock