* platform_driver/of_platform_driver compile warning in fsldma.c
@ 2011-04-08 9:12 Kumar Gala
2011-04-08 15:32 ` Ira W. Snyder
0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2011-04-08 9:12 UTC (permalink / raw)
To: Grant Likely; +Cc: Linuxppc-dev list
Grant,
I'm being lazy, can you give any quick insight on the following compile =
warning:
drivers/dma/fsldma.c:1457:2: warning: initialization from incompatible =
pointer type
drivers/dma/fsldma.c: In function 'fsldma_init':
drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of =
'platform_driver_register' from incompatible pointer type
include/linux/platform_device.h:124:12: note: expected 'struct =
platform_driver *' but argument is of type 'struct of_platform_driver *'
drivers/dma/fsldma.c: In function 'fsldma_exit':
drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of =
'platform_driver_unregister' from incompatible pointer type
include/linux/platform_device.h:125:13: note: expected 'struct =
platform_driver *' but argument is of type 'struct of_platform_driver *'
- k=
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: platform_driver/of_platform_driver compile warning in fsldma.c
2011-04-08 9:12 platform_driver/of_platform_driver compile warning in fsldma.c Kumar Gala
@ 2011-04-08 15:32 ` Ira W. Snyder
2011-04-08 16:56 ` Grant Likely
2011-04-09 14:40 ` Kumar Gala
0 siblings, 2 replies; 4+ messages in thread
From: Ira W. Snyder @ 2011-04-08 15:32 UTC (permalink / raw)
To: Kumar Gala; +Cc: Linuxppc-dev list
On Fri, Apr 08, 2011 at 04:12:13AM -0500, Kumar Gala wrote:
> Grant,
>
> I'm being lazy, can you give any quick insight on the following compile warning:
>
> drivers/dma/fsldma.c:1457:2: warning: initialization from incompatible pointer type
> drivers/dma/fsldma.c: In function 'fsldma_init':
> drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of 'platform_driver_register' from incompatible pointer type
> include/linux/platform_device.h:124:12: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
> drivers/dma/fsldma.c: In function 'fsldma_exit':
> drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of 'platform_driver_unregister' from incompatible pointer type
> include/linux/platform_device.h:125:13: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
>
The "struct of_platform_driver" needs to be changed to a
"struct platform_driver". Just remove the "of_" prefix, the structure
initialization is correct. I sent a patch for this yesterday to LKML. The
title is: fsldma: fix build warning caused by of_platform_device changes
Ira
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: platform_driver/of_platform_driver compile warning in fsldma.c
2011-04-08 15:32 ` Ira W. Snyder
@ 2011-04-08 16:56 ` Grant Likely
2011-04-09 14:40 ` Kumar Gala
1 sibling, 0 replies; 4+ messages in thread
From: Grant Likely @ 2011-04-08 16:56 UTC (permalink / raw)
To: Ira W. Snyder; +Cc: Linuxppc-dev list
On Fri, Apr 8, 2011 at 8:32 AM, Ira W. Snyder <iws@ovro.caltech.edu> wrote:
> On Fri, Apr 08, 2011 at 04:12:13AM -0500, Kumar Gala wrote:
>> Grant,
>>
>> I'm being lazy, can you give any quick insight on the following compile warning:
>>
>> drivers/dma/fsldma.c:1457:2: warning: initialization from incompatible pointer type
>> drivers/dma/fsldma.c: In function 'fsldma_init':
>> drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of 'platform_driver_register' from incompatible pointer type
>> include/linux/platform_device.h:124:12: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
>> drivers/dma/fsldma.c: In function 'fsldma_exit':
>> drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of 'platform_driver_unregister' from incompatible pointer type
>> include/linux/platform_device.h:125:13: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
>>
>
> The "struct of_platform_driver" needs to be changed to a
> "struct platform_driver". Just remove the "of_" prefix, the structure
> initialization is correct. I sent a patch for this yesterday to LKML. The
> title is: fsldma: fix build warning caused by of_platform_device changes
Yes, thanks Ira. I'm picking up that patch today and I'll send it off to Linus.
g.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: platform_driver/of_platform_driver compile warning in fsldma.c
2011-04-08 15:32 ` Ira W. Snyder
2011-04-08 16:56 ` Grant Likely
@ 2011-04-09 14:40 ` Kumar Gala
1 sibling, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2011-04-09 14:40 UTC (permalink / raw)
To: Ira W. Snyder; +Cc: Linuxppc-dev list
On Apr 8, 2011, at 10:32 AM, Ira W. Snyder wrote:
> On Fri, Apr 08, 2011 at 04:12:13AM -0500, Kumar Gala wrote:
>> Grant,
>>=20
>> I'm being lazy, can you give any quick insight on the following =
compile warning:
>>=20
>> drivers/dma/fsldma.c:1457:2: warning: initialization from =
incompatible pointer type
>> drivers/dma/fsldma.c: In function 'fsldma_init':
>> drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of =
'platform_driver_register' from incompatible pointer type
>> include/linux/platform_device.h:124:12: note: expected 'struct =
platform_driver *' but argument is of type 'struct of_platform_driver *'
>> drivers/dma/fsldma.c: In function 'fsldma_exit':
>> drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of =
'platform_driver_unregister' from incompatible pointer type
>> include/linux/platform_device.h:125:13: note: expected 'struct =
platform_driver *' but argument is of type 'struct of_platform_driver *'
>>=20
>=20
> The "struct of_platform_driver" needs to be changed to a
> "struct platform_driver". Just remove the "of_" prefix, the structure
> initialization is correct. I sent a patch for this yesterday to LKML. =
The
> title is: fsldma: fix build warning caused by of_platform_device =
changes
>=20
> Ira
Ira, thanks. Hopefully it will get picked up. If not let me know.
- k=
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-09 14:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-08 9:12 platform_driver/of_platform_driver compile warning in fsldma.c Kumar Gala
2011-04-08 15:32 ` Ira W. Snyder
2011-04-08 16:56 ` Grant Likely
2011-04-09 14:40 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).