From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next-2.6 1/2] gianfar: Clean up implementation of RX network flow classification
Date: Mon, 11 Apr 2011 13:29:09 -0700 (PDT) [thread overview]
Message-ID: <20110411.132909.232734437.davem@davemloft.net> (raw)
In-Reply-To: <1302306311.2871.56.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 09 Apr 2011 00:45:11 +0100
> This code was cribbed from niu, so gfar_set_hash_opts() begins by
> converting the ethtool flow class code into a class code for Sun
> Neptune hardware, then does the same thing again for the hardware it's
> really dealing with. It may also return -1 (-EPERM) for some
> unhandled ethtool flow class codes.
>
> Remove the useless code and definitions, and fix the error code.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> This isn't even compile-tested, since it can only be built for some
> PowerPC SoCs. Could someone on ppc-dev check that this won't break the
> driver?
I'm applying this, it looks so trivial to me that I'm willing to take
the build risk :-)
Thanks.
prev parent reply other threads:[~2011-04-11 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 23:45 [PATCH net-next-2.6 1/2] gianfar: Clean up implementation of RX network flow classification Ben Hutchings
2011-04-11 20:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411.132909.232734437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).