From: Michael Guntsche <mike@it-loops.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Powerpc compile error with 2.6.39-rc3 and non-SMP configs
Date: Wed, 13 Apr 2011 12:17:37 +0200 [thread overview]
Message-ID: <20110413101737.GA25514@gibson.comsick.at> (raw)
Hi,
Commit b987812b3fc "powerpc/kexec: Fix mismatched ifdefs for PPC64/SMP."
breaks compilation on non SMP powerpc machines.
I wonder if this commit is really neccessary in the first place. The
function definition itself is already between an
#ifdef CONFIG_SMP (line 56)
#endif
block so only exists if SMP=y and PPC_STD_MMU_64=y.
Furthermore the stub in your patch is only created if SMP=y and
PPC_STD_MMU_64=n which breaks non-SMP configs.
Kind regards,
Michael Guntsche
next reply other threads:[~2011-04-13 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 10:17 Michael Guntsche [this message]
2011-04-13 15:45 ` Powerpc compile error with 2.6.39-rc3 and non-SMP configs Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413101737.GA25514@gibson.comsick.at \
--to=mike@it-loops.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).