From: Stefan Roese <ml@stefan-roese.de>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: Scott Wood <scottwood@freescale.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: FTrace on MPC8xx
Date: Fri, 15 Apr 2011 09:22:42 +0200 [thread overview]
Message-ID: <201104150922.43093.ml@stefan-roese.de> (raw)
In-Reply-To: <OFDD77B7E3.D5C79015-ONC1257872.0069E657-C1257872.006A5415@transmode.se>
Hi Joakim,
On Thursday 14 April 2011 21:21:23 Joakim Tjernlund wrote:
> > hmm, I guess 8xx really maps kernel RO as RO :) Try
> >
> > changing in pte-8xx.h:
> > - #define _PAGE_KERNEL_RO (_PAGE_SHARED)
> > + #define _PAGE_KERNEL_RO (_PAGE_RW |_PAGE_SHARED)
>
> hmm, I wonder if not this is the problem(in pte-common.h)
> #if defined(CONFIG_KGDB) || defined(CONFIG_XMON) ||
> defined(CONFIG_BDI_SWITCH) ||\ defined(CONFIG_KPROBES)
> #define PAGE_KERNEL_TEXT PAGE_KERNEL_X
> #else
> #define PAGE_KERNEL_TEXT PAGE_KERNEL_ROX
> #endif
>
> What is PAGE_KERNEL_TEXT for you?
> I think it must be PAGE_KERNEL_X, otherwise kernel text will be readonly.
Yes, that's it! Its PAGE_KERNEL_ROX right now. We need to add CONFIG_FTRACE or
at least CONFIG_DYNAMIC_FTRACE to the #if statement above.
Do you want to send a patch (since you detected the real problem)? Or should I
do this?
Thanks.
Best regards,
Stefan
next prev parent reply other threads:[~2011-04-15 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 14:32 FTrace on MPC8xx Stefan Roese
2011-04-13 14:58 ` Joakim Tjernlund
2011-04-13 15:21 ` Stefan Roese
2011-04-13 15:38 ` Joakim Tjernlund
2011-04-14 15:59 ` Stefan Roese
2011-04-14 16:49 ` Joakim Tjernlund
2011-04-14 19:21 ` Joakim Tjernlund
2011-04-15 7:22 ` Stefan Roese [this message]
2011-04-15 8:46 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104150922.43093.ml@stefan-roese.de \
--to=ml@stefan-roese.de \
--cc=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox