* [PATCH] powerpc: Fix kexec-related UP build error
@ 2011-04-15 20:29 Paul E. McKenney
2011-04-15 21:00 ` Nishanth Aravamudan
0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2011-04-15 20:29 UTC (permalink / raw)
To: linuxppc-dev; +Cc: ebiederm, paulus, linux-kernel, kexec
Hello!
The following patch fixes a UP build problem for kexec() on powerpc.
When the crash_kexec_wait_realmode() function was added, it was
placed in only two of the three required locations.
Thoughts?
Thanx, Paul
------------------------------------------------------------------------
The function crash_kexec_wait_realmode() is defined only if SMP, but is
called in UP builds. Create an empty function to keep the compiler happy
in UP builds.
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
index 3d3d416..6f964ef 100644
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -251,6 +251,10 @@ static void crash_kexec_prepare_cpus(int cpu)
#endif
}
+static void crash_kexec_wait_realmode(int cpu)
+{
+}
+
void crash_kexec_secondary(struct pt_regs *regs)
{
cpus_in_sr = CPU_MASK_NONE;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: Fix kexec-related UP build error
2011-04-15 20:29 [PATCH] powerpc: Fix kexec-related UP build error Paul E. McKenney
@ 2011-04-15 21:00 ` Nishanth Aravamudan
2011-04-15 21:08 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Aravamudan @ 2011-04-15 21:00 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: paulus, linuxppc-dev, ebiederm, kexec, linux-kernel
Hi Paul,
On 15.04.2011 [13:29:16 -0700], Paul E. McKenney wrote:
> Hello!
>
> The following patch fixes a UP build problem for kexec() on powerpc.
> When the crash_kexec_wait_realmode() function was added, it was
> placed in only two of the three required locations.
I believe the fix has already been posted as
http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html
Thanks,
Nish
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix kexec-related UP build error
2011-04-15 21:00 ` Nishanth Aravamudan
@ 2011-04-15 21:08 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2011-04-15 21:08 UTC (permalink / raw)
To: Nishanth Aravamudan; +Cc: paulus, linuxppc-dev, ebiederm, kexec, linux-kernel
On Fri, Apr 15, 2011 at 02:00:51PM -0700, Nishanth Aravamudan wrote:
> Hi Paul,
>
> On 15.04.2011 [13:29:16 -0700], Paul E. McKenney wrote:
> > Hello!
> >
> > The following patch fixes a UP build problem for kexec() on powerpc.
> > When the crash_kexec_wait_realmode() function was added, it was
> > placed in only two of the three required locations.
>
> I believe the fix has already been posted as
>
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html
So it has! Thank you for the pointer.
Thanx, Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-15 21:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 20:29 [PATCH] powerpc: Fix kexec-related UP build error Paul E. McKenney
2011-04-15 21:00 ` Nishanth Aravamudan
2011-04-15 21:08 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).