From: Anton Blanchard <anton@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: tsenglin@us.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Add Initiate Coprocessor Store Word (icswx) support
Date: Tue, 3 May 2011 16:55:20 +1000 [thread overview]
Message-ID: <20110503165520.67eab924@kryten> (raw)
In-Reply-To: <1304405237.2513.304.camel@pasglop>
Hi Ben,
> My only comment (sorry Anton :-) would have been that we could lazily
> allocate the spinlock on the first use_cop() ... or do we have that
> potentially called in the wrong context ?
I worry what might happen in a threaded app. It would be a strange
thing to do, but the program may call use_cop from two threads at the
same time. In that case you could corrupt the PID/ACOP values
and leak a spinlock of memory I think.
Anton
next prev parent reply other threads:[~2011-05-03 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 6:43 [PATCH] powerpc: Add Initiate Coprocessor Store Word (icswx) support Anton Blanchard
2011-05-03 6:47 ` Benjamin Herrenschmidt
2011-05-03 6:55 ` Anton Blanchard [this message]
2011-05-03 8:57 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2011-04-18 1:36 Anton Blanchard
2011-04-24 6:05 ` Benjamin Herrenschmidt
2011-03-25 21:32 Anton Blanchard
2011-03-28 15:26 ` Kumar Gala
2011-03-28 19:08 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503165520.67eab924@kryten \
--to=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tsenglin@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).