From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev@ozlabs.org, kvm@vger.kernel.org
Subject: Re: [PATCH 11/13] kvm/powerpc: Handle some PAPR hcalls in the kernel
Date: Tue, 17 May 2011 20:28:40 +1000 [thread overview]
Message-ID: <20110517102840.GA7924@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <2C53DD5C-4F74-4FC4-9C65-4F401AE9AF78@suse.de>
On Tue, May 17, 2011 at 09:54:35AM +0200, Alexander Graf wrote:
> Not sure I like the name - when is it used? :)
When the real-mode hcall handler decides it can't handle the hcall and
wants to pass it up.
> Also, if it's not in the PAPR, the guest should never receive it, right?
Right. It's purely an internal value.
> > + /* See if this is something we can handle in real mode */
> > + cmpwi r12,0xc00
>
> use the define please
OK
> > + beq hcall_real_mode
>
> This is simply a hcall helper, as the name suggests. So the comment
> is slightly misleading - it should rather read like "Try to handle
> hypercalls in real mode".
Hmmm, OK, that's what it was trying to indicate. I could add "try" to
the name if you like.
> > + cmpdi r3,H_TOO_HARD
> > + beq hcall_real_fallback
>
> Ah, very good. Please mark the constant as "for internal use only"
> then, as that's certainly fine :).
Cool, will do.
> > + li r12,0xc00
>
> use the define please :)
OK.
Thanks,
Paul.
next prev parent reply other threads:[~2011-05-17 10:28 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 10:34 [PATCH 0/13] Hypervisor-mode KVM on POWER7 Paul Mackerras
2011-05-11 10:36 ` [PATCH 01/13] kvm/powerpc: Move fields between struct kvm_vcpu_arch and kvmppc_vcpu_book3s Paul Mackerras
2011-05-11 10:38 ` [PATCH 02/13] kvm/powerpc: Fix kvmppc_core_pending_dec Paul Mackerras
2011-05-11 10:39 ` [PATCH 03/13] kvm/powerpc: Fix the build for 32-bit Book 3S (classic) processors Paul Mackerras
2011-05-12 9:33 ` Alexander Graf
2011-05-12 11:15 ` Paul Mackerras
2011-05-12 11:16 ` Benjamin Herrenschmidt
2011-05-12 11:57 ` Alexander Graf
2011-05-11 10:40 ` [PATCH 04/13] kvm/powerpc: Split out code from book3s.c into book3s_pr.c Paul Mackerras
2011-05-11 10:41 ` [PATCH 05/13] powerpc, kvm: Rework KVM checks in first-level interrupt handlers Paul Mackerras
2011-05-11 10:42 ` [PATCH 06/13] kvm/powerpc: Deliver program interrupts right away instead of queueing them Paul Mackerras
2011-05-11 10:42 ` [PATCH 07/13] kvm/powerpc: Pass init/destroy vm and prepare/commit memory region ops down Paul Mackerras
2011-05-11 10:43 ` [PATCH 08/13] kvm/powerpc: Move guest enter/exit down into subarch-specific code Paul Mackerras
2011-05-17 18:05 ` Marcelo Tosatti
2011-05-17 18:10 ` Marcelo Tosatti
2011-05-11 10:44 ` [PATCH 09/13] powerpc: Set up LPCR for running guest partitions Paul Mackerras
2011-05-11 10:44 ` [PATCH 10/13] kvm/powerpc: Add support for Book3S processors in hypervisor mode Paul Mackerras
2011-05-12 9:07 ` Avi Kivity
2011-05-16 1:07 ` Paul Mackerras
2011-05-15 21:58 ` Alexander Graf
2011-05-16 5:58 ` Paul Mackerras
2011-05-17 10:17 ` Alexander Graf
2011-05-27 10:33 ` Paul Mackerras
2011-05-27 10:43 ` Alexander Graf
2011-05-27 20:59 ` Segher Boessenkool
2011-05-27 23:19 ` Alexander Graf
2011-05-28 1:07 ` Segher Boessenkool
2011-05-31 20:26 ` Jimi Xenidis
2011-05-31 22:34 ` Segher Boessenkool
2011-06-01 5:11 ` Paul Mackerras
2011-05-11 10:45 ` [PATCH 11/13] kvm/powerpc: Handle some PAPR hcalls in the kernel Paul Mackerras
2011-05-17 7:54 ` Alexander Graf
2011-05-17 10:28 ` Paul Mackerras [this message]
2011-05-11 10:46 ` [PATCH 12/13] kvm/powerpc: Accelerate H_PUT_TCE by implementing it in real mode Paul Mackerras
2011-05-17 8:01 ` Alexander Graf
2011-05-17 9:11 ` Benjamin Herrenschmidt
2011-05-17 9:31 ` Alexander Graf
2011-05-17 9:35 ` Benjamin Herrenschmidt
2011-05-17 9:39 ` Alexander Graf
2011-05-11 10:46 ` [PATCH 13/13] kvm/powerpc: Allow book3s_hv guests to use SMT processor modes Paul Mackerras
2011-05-11 13:44 ` Christoph Hellwig
2011-05-11 21:17 ` Paul Mackerras
2011-05-17 8:21 ` Alexander Graf
2011-05-17 10:44 ` Paul Mackerras
2011-05-17 11:36 ` Alexander Graf
2011-05-19 6:06 ` Paul Mackerras
2011-05-17 9:46 ` [PATCH 0/13] Hypervisor-mode KVM on POWER7 Alexander Graf
2011-05-17 11:15 ` Paul Mackerras
2011-05-17 11:38 ` Alexander Graf
2011-05-17 11:42 ` Avi Kivity
2011-05-19 5:22 ` Paul Mackerras
2011-05-19 6:01 ` Alexander Graf
2011-05-21 16:41 ` Alexander Graf
2011-05-21 17:00 ` Alexander Graf
2011-05-21 18:15 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517102840.GA7924@brick.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).