From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 19 May 2011 10:46:25 -0700 From: Nishanth Aravamudan To: Benjamin Herrenschmidt Subject: Re: [PATCH 5/8] powerpc: override dma_get_required_mask by platform hook and ops Message-ID: <20110519174625.GA3338@us.ibm.com> References: <1305152704-4864-1-git-send-email-nacc@us.ibm.com> <1305152704-4864-6-git-send-email-nacc@us.ibm.com> <1305791036.7481.52.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1305791036.7481.52.camel@pasglop> Cc: cbe-oss-dev@lists.ozlabs.org, FUJITA Tomonori , Arnd Bergmann , Sonny Rao , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , Paul Mackerras , Anton Blanchard , Will Schmidt , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 19.05.2011 [17:43:56 +1000], Benjamin Herrenschmidt wrote: > On Wed, 2011-05-11 at 15:25 -0700, Nishanth Aravamudan wrote: > > From: Milton Miller > > > > The hook dma_get_required_mask is supposed to return the mask required > > by the platform to operate efficently. The generic version of > > dma_get_required_mask in driver/base/platform.c returns a mask based > > only on max_pfn. However, this is likely too big for iommu systems > > and could be too small for platforms that require a dma offset or have > > a secondary window at a high offset. > > The result of those 3 patches doesn't build on top of my current tree, > the generic dma_ops lacks the dma_get_required_mask hook. I'll have a > look again after the merge window. Hrm, I think it's because for whatever reason [1] I forgot to cc you on 6/8? https://lkml.org/lkml/2011/5/11/473 -Nish [1] AKA over-reliance on get_maintainer.pl and lack of mental oversight! -- Nishanth Aravamudan IBM Linux Technology Center