From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.mail.elte.hu (mx2.mail.elte.hu [157.181.151.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7B14EB6F93 for ; Wed, 25 May 2011 05:55:21 +1000 (EST) Date: Tue, 24 May 2011 21:54:35 +0200 From: Ingo Molnar To: Peter Zijlstra Subject: Re: [PATCH 3/5] v2 seccomp_filters: Enable ftrace-based system call filtering Message-ID: <20110524195435.GC27634@elte.hu> References: <20110516165249.GB10929@elte.hu> <1305565422.5456.21.camel@gandalf.stny.rr.com> <20110517124212.GB21441@elte.hu> <1305637528.5456.723.camel@gandalf.stny.rr.com> <20110517131902.GF21441@elte.hu> <1305807728.11267.25.camel@gandalf.stny.rr.com> <1306254027.18455.47.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1306254027.18455.47.camel@twins> Cc: linux-mips@linux-mips.org, linux-sh@vger.kernel.org, Frederic Weisbecker , Heiko Carstens , Oleg Nesterov , David Howells , Paul Mackerras , Eric Paris , "H. Peter Anvin" , sparclinux@vger.kernel.org, Jiri Slaby , linux-s390@vger.kernel.org, Russell King , x86@kernel.org, James Morris , Linus Torvalds , Ingo Molnar , kees.cook@canonical.com, "Serge E. Hallyn" , Steven Rostedt , Tejun Heo , Thomas Gleixner , linux-arm-kernel , Michal Marek , Michal Simek , Will Drewry , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mundt , Martin Schwidefsky , linux390@de.ibm.com, Andrew Morton , agl@chromium.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Peter Zijlstra wrote: > On Tue, 2011-05-24 at 10:59 -0500, Will Drewry wrote: > > include/linux/ftrace_event.h | 4 +- > > include/linux/perf_event.h | 10 +++++--- > > kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++++++++--- > > kernel/seccomp.c | 8 ++++++ > > kernel/trace/trace_syscalls.c | 27 +++++++++++++++++----- > > 5 files changed, 82 insertions(+), 16 deletions(-) > > I strongly oppose to the perf core being mixed with any sekurity voodoo > (or any other active role for that matter). I'd object to invisible side-effects as well, and vehemently so. But note how intelligently it's used here: it's explicit in the code, it's used explicitly in kernel/seccomp.c and the event generation place in kernel/trace/trace_syscalls.c. So this is a really flexible solution IMO and does not extend events with some invisible 'active' role. It extends the *call site* with an open-coded active role - which active role btw. already pre-existed. Thanks, Ingo