From: Wolfram Sang <w.sang@pengutronix.de>
To: rtc-linux@googlegroups.com
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
Jain Priyanka-B32167 <B32167@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"p_gortmaker@yahoo.com" <p_gortmaker@yahoo.com>
Subject: Re: [rtc-linux] Re: [PATCH] Add support for pt7c4338 (rtc device) in rtc-ds1307 driver
Date: Mon, 30 May 2011 16:50:34 +0200 [thread overview]
Message-ID: <20110530145034.GE3409@pengutronix.de> (raw)
In-Reply-To: <BANLkTi=H2rHSjTvRK5+SPhW26qCNUBMxbA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
> > IIRC I asked you explicitly for the differences between the chips. If
> > there are none, you can use the driver directly, right? :)
>
> Yes. The device tree node for the PT7C4338 device should just say
>
> /* The board has a PT7C4338, which is compatible with the DS1307 */
> compatible = "dallas,ds1307";
>
> And that's it.
I'd also suggest to add a comment to the id_table in rtc-ds1307.c, so
the chip name can be grepped for.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-05-30 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 7:03 [PATCH] Add support for pt7c4338 (rtc device) in rtc-ds1307 driver Priyanka Jain
2011-05-26 9:10 ` Wolfram Sang
2011-05-30 4:47 ` Jain Priyanka-B32167
2011-05-30 8:24 ` Wolfram Sang
2011-05-30 14:29 ` [rtc-linux] " Tabi Timur-B04825
2011-05-30 14:50 ` Wolfram Sang [this message]
2011-05-30 16:57 ` Anton Vorontsov
2011-06-03 18:03 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530145034.GE3409@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B32167@freescale.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).