From: Scott Wood <scottwood@freescale.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>,
Anton Vorontsov <avorontsov@mvista.com>,
linuxppc-dev@lists.ozlabs.org,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device
Date: Wed, 1 Jun 2011 11:48:23 -0500 [thread overview]
Message-ID: <20110601114823.2e57c691@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <BANLkTi=xFcZRd4x1FQSKJzmt3A7_tZs+sQ@mail.gmail.com>
On Wed, 1 Jun 2011 18:55:35 +0400
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
> On 6/1/11, Anton Vorontsov <avorontsov@mvista.com> wrote:
> > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote:
> > [...]
> > Also, why not add this call to the fsl_add_bridge(), so you
> > won't need to touch board files at all.
>
> Because fsl_add_bridge is called too early, so allocation
> of platform device fails.
That doesn't seem like a good reason for putting more stuff in board
files that isn't board-specific. Why not just make fsl_add_pci_err() an
initcall? It already only works when a compatible device tree node is
found. Is there any case where a board would not want this PCI code to be
used, even if the device tree node is present? If so, fsl_add_bridge could
set a flag that fsl_add_pci_err() could check -- but I doubt it's needed.
-Scott
next prev parent reply other threads:[~2011-06-01 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 12:28 [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device Dmitry Eremin-Solenikov
2011-06-01 12:28 ` [PATCH 2/2] mpc85xx_edac: adapt to ppc/85xx changes for mpc85xx_pci_err Dmitry Eremin-Solenikov
2011-06-01 13:25 ` [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device Anton Vorontsov
2011-06-01 14:55 ` Dmitry Eremin-Solenikov
2011-06-01 14:59 ` Anton Vorontsov
2011-06-01 16:08 ` Dmitry Eremin-Solenikov
2011-06-01 16:48 ` Scott Wood [this message]
2011-06-02 12:25 ` Dmitry Eremin-Solenikov
2011-06-02 15:14 ` Anton Vorontsov
2011-06-02 15:15 ` David Laight
2011-06-02 17:48 ` Scott Wood
2011-06-04 10:42 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601114823.2e57c691@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=avorontsov@mvista.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dbaryshkov@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).