From: Richard Weinberger <richard@nod.at>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, heiko.carstens@de.ibm.com,
oleg@redhat.com, paulus@samba.org, ralf@linux-mips.org,
hpa@zytor.com, sparclinux@vger.kernel.org,
linux-s390@vger.kernel.org, x86@kernel.org, mingo@redhat.com,
fenghua.yu@intel.com,
user-mode-linux-devel@lists.sourceforge.net,
microblaze-uclinux@itee.uq.edu.au, jdike@addtoit.com,
viro@zeniv.linux.org.uk, tglx@linutronix.de, monstr@monstr.eu,
linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
lethal@linux-sh.org, schwidefsky@de.ibm.com, linux390@de.ibm.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
Date: Fri, 3 Jun 2011 01:03:46 +0200 [thread overview]
Message-ID: <201106030103.46742.richard@nod.at> (raw)
In-Reply-To: <BANLkTik9kCs_06=7HKo44cWqpS0zB9fr+A@mail.gmail.com>
Am Freitag 03 Juni 2011, 01:00:51 schrieb Tony Luck:
> > But there seems to be another problem.
> > Why is pt_regs of type void *?
> >=20
> > gcc complains:
> > In file included from include/linux/fsnotify.h:15:0,
> > from include/linux/security.h:26,
> > from init/main.c:32:
> > include/linux/audit.h: In function =91audit_syscall_exit=92:
> > include/linux/audit.h:440:17: warning: dereferencing =91void *=92 point=
er
> > include/linux/audit.h:440:3: error: invalid use of void expression
> > include/linux/audit.h:441:21: warning: dereferencing =91void *=92 point=
er
> > include/linux/audit.h:441:21: error: void value not ignored as it ought
> > to be
>=20
> Perhaps same issue on ia64 - but symptoms are different:
The void * pointer is the problem.
On UML it builds fine when I cast it:
#define regs_return_value(r) UPT_SYSCALL_RET((struct uml_pt_regs *)r)
I'll test it tomorrow in detail, for now I'm too sleepy.
Thanks,
//richard
next prev parent reply other threads:[~2011-06-02 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 21:04 [PATCH] Audit: push audit success and retcode into arch ptrace.h Eric Paris
2011-06-02 21:18 ` H. Peter Anvin
2011-06-02 22:32 ` Richard Weinberger
2011-06-02 23:00 ` Tony Luck
2011-06-02 23:03 ` Richard Weinberger [this message]
2011-06-02 23:07 ` Eric Paris
2011-06-02 23:06 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106030103.46742.richard@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=lethal@linux-sh.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).