linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ayman El-Khashab <ayman@elkhashab.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: cam@cs.ualberta.ca
Subject: powerpc/4xx: Regression failed on sil24 (and other) drivers
Date: Sat, 25 Jun 2011 18:52:59 -0500	[thread overview]
Message-ID: <20110625235259.GA18837@crust.elkhashab.com> (raw)

I noticed during a recent development with the 460SX that a
simple device that once worked stopped.  I did a bisect to
find the offending commit and it turns out to be this one:

0e52247a2ed1f211f0c4f682dc999610a368903f is the first bad
commit
commit 0e52247a2ed1f211f0c4f682dc999610a368903f
Author: Cam Macdonell <cam@cs.ualberta.ca>
Date:   Tue Sep 7 17:25:20 2010 -0700

    PCI: fix pci_resource_alignment prototype

I found it working with 2.6.36 but it seems that it is in
the current trunk as well.

I patched my code to take out this commit and (quickly)
verified it was ok.  I am guessing the patch is ok since it
converts int types to resource_size_t.  My guess is that the
problem is in the sil24 driver but I did not see anything 
obvious in that code.  Any tips on what could be wrong?  Is
the problem potentially somewhere being called by that code?

The device driver fails with "error -22" on a 460SX (which 
has the 36 bit pci space).

sil24 /drivers/ata/sata_sil24.c

Thanks
Ayman

             reply	other threads:[~2011-06-25 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-25 23:52 Ayman El-Khashab [this message]
2011-06-27 10:19 ` powerpc/4xx: Regression failed on sil24 (and other) drivers Benjamin Herrenschmidt
2011-06-27 11:31   ` Ayman El-Khashab
2011-06-27 12:29     ` Benjamin Herrenschmidt
2011-06-29  1:42     ` Benjamin Herrenschmidt
2011-06-29 18:13       ` Ayman El-Khashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110625235259.GA18837@crust.elkhashab.com \
    --to=ayman@elkhashab.com \
    --cc=cam@cs.ualberta.ca \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).