From: Scott Wood <scottwood@freescale.com>
To: "Matthew L. Creech" <mlcreech@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org,
rick22@wi.rr.com, mhench@elutions.com
Subject: Re: [PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi
Date: Tue, 5 Jul 2011 18:01:38 -0500 [thread overview]
Message-ID: <20110705180138.469f34d1@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <1309905302-1990-1-git-send-email-mlcreech@gmail.com>
On Tue, 5 Jul 2011 18:35:02 -0400
"Matthew L. Creech" <mlcreech@gmail.com> wrote:
> From: Mike Hench <mhench@elutions.com>
>
> The eLBC NAND driver currently follows up each program/write operation with a
> read-back of the page, in order to [ostensibly] fill in ECC data for the
> caller. However, the page address used for this read is always -1, so the read
> will never work correctly. Remove this useless (and potentially problematic)
> block of code.
>
> v2: elbc_fcm_ctrl->oob_poi is removed entirely, since this code block was the
> only place it was actually used.
Just noticed, full_page can come out as well.
Otherwise, ACK
-Scott
next prev parent reply other threads:[~2011-07-05 23:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 20:54 NAND BBT corruption on MPC83xx Matthew L. Creech
2011-06-17 21:34 ` Scott Wood
2011-06-18 17:55 ` Mike Hench
2011-06-20 11:22 ` Atlant Schmidt
2011-06-23 8:31 ` Artem Bityutskiy
2011-06-20 15:20 ` Matthew L. Creech
2011-07-05 19:58 ` Matthew L. Creech
2011-07-05 19:59 ` [PATCH] mtd: eLBC NAND: remove bogus ECC read-back Matthew L. Creech
2011-07-05 20:15 ` Scott Wood
2011-07-05 22:35 ` [PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi Matthew L. Creech
2011-07-05 23:01 ` Scott Wood [this message]
2011-07-05 23:14 ` Matthew L. Creech
2011-07-05 23:14 ` [PATCH v3] " Matthew L. Creech
2011-07-06 7:23 ` Artem Bityutskiy
2011-07-11 15:30 ` NAND BBT corruption on MPC83xx Matthew L. Creech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705180138.469f34d1@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhench@elutions.com \
--cc=mlcreech@gmail.com \
--cc=rick22@wi.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).