From: Anton Blanchard <anton@samba.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/kdump: Fix timeout in crash_kexec_wait_realmode
Date: Wed, 6 Jul 2011 17:55:29 +1000 [thread overview]
Message-ID: <20110706175529.5cdacb17@kryten> (raw)
In-Reply-To: <29259.1309848010@neuling.org>
On Tue, 05 Jul 2011 16:40:10 +1000
Michael Neuling <mikey@neuling.org> wrote:
> The existing code it pretty ugly. How about we clean it up even more
> like this?
Looks good and it passed my kdump test cases.
Anton
> From: Anton Blanchard <anton@samba.org>
>
> We check for timeout expiry in the outer loop, but we also need to
> check it in the inner loop or we can lock up forever waiting for a
> CPU to hit real mode.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> Cc: <stable@kernel.org>
>
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 4e6ee94..cc6a9d5 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -242,12 +242,8 @@ static void crash_kexec_wait_realmode(int cpu)
>
> while (paca[i].kexec_state < KEXEC_STATE_REAL_MODE) {
> barrier();
> - if (!cpu_possible(i)) {
> + if (!cpu_possible(i) || !cpu_online(i) ||
> (msecs <= 0)) break;
> - }
> - if (!cpu_online(i)) {
> - break;
> - }
> msecs--;
> mdelay(1);
> }
>
prev parent reply other threads:[~2011-07-06 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 6:12 [PATCH] powerpc/kdump: Fix timeout in crash_kexec_wait_realmode Anton Blanchard
2011-07-05 6:40 ` Michael Neuling
2011-07-06 7:55 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706175529.5cdacb17@kryten \
--to=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).