From: David Miller <davem@davemloft.net>
To: ronny.meeus@gmail.com
Cc: linuxppc-dev@ozlabs.org, afleming@freescale.com,
patrickdepinguin+linuxppc@gmail.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: softirqs are invoked while bottom halves are masked
Date: Tue, 12 Jul 2011 05:13:16 -0700 (PDT) [thread overview]
Message-ID: <20110712.051316.1963034055315982365.davem@davemloft.net> (raw)
In-Reply-To: <20110712.050817.1253941735409335652.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 12 Jul 2011 05:08:17 -0700 (PDT)
> From: Ronny Meeus <ronny.meeus@gmail.com>
> Date: Tue, 12 Jul 2011 14:03:04 +0200
>
>> but we still see the issue "BUG: sleeping function called from invalid context":
>>
>> [ 91.015989] BUG: sleeping function called from invalid context at
>> include/linux/skbuff.h:786
>> [ 91.117096] in_atomic(): 1, irqs_disabled(): 0, pid: 1865, name: NMTX_T1842
>> [ 91.200461] Call Trace:
>> [ 91.229672] [ec58bbd0] [c000789c] show_stack+0x78/0x18c (unreliable)
>> [ 91.305791] [ec58bc10] [c0022900] __might_sleep+0x100/0x118
>> [ 91.372524] [ec58bc20] [c029f8d8] dpa_tx+0x128/0x758
>
> Because this dpa driver's transmit method is doing something else that
> is not allowed in software interrupt context.
>
> You must remove all things that might sleep in this driver's
> ->ndo_start_xmit method, and I do mean everything.
Also this whole HW QOS feature bit facility is beyond bogus.
What if the user enables a qdisc that the hardware can't handle, or a
configuration of a hw supported qdisc that the hardware can't support?
What if I have packet classification and packet actions enabled in the
packet scheduler?
These changes are terrible, and we really need you guys to sort out
your problems with these changes yoursleves because your wounds are
entirely self-inflicted and totally not our problem.
next prev parent reply other threads:[~2011-07-12 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 9:23 softirqs are invoked while bottom halves are masked (was: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface) Thomas De Schampheleire
2011-07-12 10:01 ` softirqs are invoked while bottom halves are masked David Miller
2011-07-12 10:10 ` softirqs are invoked while bottom halves are masked (was: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface) Eric Dumazet
2011-07-12 12:03 ` Ronny Meeus
2011-07-12 12:08 ` softirqs are invoked while bottom halves are masked David Miller
2011-07-12 12:13 ` David Miller [this message]
2011-07-13 7:20 ` Thomas De Schampheleire
2011-07-13 7:38 ` Eric Dumazet
2011-07-12 15:27 ` softirqs are invoked while bottom halves are masked (was: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface) Eric Dumazet
2011-07-12 19:52 ` Ronny Meeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712.051316.1963034055315982365.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=eric.dumazet@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=patrickdepinguin+linuxppc@gmail.com \
--cc=ronny.meeus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).