From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Ayman El-Khashab <ayman@elkhashab.com>
Cc: LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops
Date: Tue, 12 Jul 2011 14:04:04 -0400 [thread overview]
Message-ID: <20110712180404.GC4203@zod.rchland.ibm.com> (raw)
In-Reply-To: <20110712174007.GA26664@crust.elkhashab.com>
On Tue, Jul 12, 2011 at 12:40:07PM -0500, Ayman El-Khashab wrote:
>On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote:
>> All current pcie controllers unconditionally use SDR to check the link and
>> poll for reset.
>
>I was able to apply this patch and then modify the 460SX to
>work correctly, so I think it is fine. There is only 1
>comment below. So how does one supply a patch atop another
>patch?
>
>Best,
>Ayman
>
>> +static int __init ppc4xx_pciex_port_reset_sdr(struct ppc4xx_pciex_port *port)
>> +{
>> + printk(KERN_INFO "PCIE%d: Checking link...\n",
>> + port->index);
>
>Its not a functional problem, but this printk belongs in the
>check link if anywhere rather than the reset.
I've got this queued in my tree locally. I can make that change before
I push it out.
josh
next prev parent reply other threads:[~2011-07-12 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 6:44 [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops Tony Breeds
2011-07-12 17:40 ` Ayman El-Khashab
2011-07-12 18:04 ` Josh Boyer [this message]
2011-07-12 22:13 ` Ayman El-Khashab
2011-07-13 0:41 ` Tony Breeds
2011-07-13 0:42 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712180404.GC4203@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=ayman@elkhashab.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).