From: Tony Breeds <tony@bakeyournoodle.com>
To: Ayman El-Khashab <ayman@elkhashab.com>
Cc: LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>,
Josh Boyer <jwboyer@linux.vnet.ibm.com>
Subject: Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops
Date: Wed, 13 Jul 2011 10:41:16 +1000 [thread overview]
Message-ID: <20110713004116.GF20597@ozlabs.org> (raw)
In-Reply-To: <20110712221338.GA30666@crust.elkhashab.com>
On Tue, Jul 12, 2011 at 05:13:38PM -0500, Ayman El-Khashab wrote:
> Ok, so let me ask the following ... will it cause trouble if
> I swap the sequence of the calls to the following in xxx_port_init
>
> ppc4xx_pciex_port_init_mapping(...)
>
> and
>
> if (ppc4xx_pciex_hwops->check_link)...
>
> The reason is that at least on the 460SX, the link check is
> done via registers in the config space. But the init_mapping is
> needed to setup some of the DCRs to make the config space work.
> In my check_link, i map the config space do the link checks
> and then unmap since a superset of the space could be mapped
> later.
This is also what I do. IIRC ppc4xx_pciex_port_init_mapping() required
things that are setup between the 2 calls.
The double Mapping is fugly but I think it should be safe.
Yours Tony
next prev parent reply other threads:[~2011-07-13 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 6:44 [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops Tony Breeds
2011-07-12 17:40 ` Ayman El-Khashab
2011-07-12 18:04 ` Josh Boyer
2011-07-12 22:13 ` Ayman El-Khashab
2011-07-13 0:41 ` Tony Breeds [this message]
2011-07-13 0:42 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713004116.GF20597@ozlabs.org \
--to=tony@bakeyournoodle.com \
--cc=ayman@elkhashab.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).