From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net (unknown [IPv6:2406:a000:f000:9500::1]) by ozlabs.org (Postfix) with ESMTP id 93BD31007D3 for ; Wed, 13 Jul 2011 12:41:27 +1000 (EST) Date: Wed, 13 Jul 2011 11:41:14 +0900 From: Simon Horman To: "Suzuki K. Poulose" Subject: Re: [PATCH] [v3] kexec-tools: ppc32: Fixup ThreadPointer for purgatory code Message-ID: <20110713024113.GA6598@verge.net.au> References: <20110712095029.18466.30735.stgit@suzukikp.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110712095029.18466.30735.stgit@suzukikp.in.ibm.com> Cc: kexec , Josh Boyer , Paul Mackerras , linux ppc dev , Vivek Goyal List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 12, 2011 at 03:20:40PM +0530, Suzuki K. Poulose wrote: > PPC32 ELF ABI expects r2 to be loaded with Thread Pointer, which is 0x7000 > bytes past the end of TCB. Though the purgatory is single threaded, it uses > TCB scratch space in vsnprintf(). This patch allocates a 1024byte TCB > and populates the TP with the address accordingly. > > Changes from V2: Avoid address overflow in TP allocation. > Changes from V1: Fixed the addr calculation for uImage support. > > > Signed-off-by: Suzuki K. Poulose > Cc: Ryan S. Arnold Thanks, applied.