linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Suzuki K. Poulose" <suzuki@in.ibm.com>
Cc: kexec <kexec@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Josh Boyer <jwboyer@linux.vnet.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2] powerpc32: Kexec support for PPC440X chipsets
Date: Thu, 14 Jul 2011 17:40:42 +0200	[thread overview]
Message-ID: <20110714154042.GA14975@linutronix.de> (raw)
In-Reply-To: <20110712064356.28567.48722.stgit@suzukikp.in.ibm.com>

* Suzuki K. Poulose | 2011-07-12 12:14:16 [+0530]:

>Changes from V1: Uses a tmp mapping in the other address space to setup
>		 the 1:1 mapping (suggested by Sebastian Andrzej Siewior).
>
>Note: Should we do the same for kernel entry code for PPC44x ?

You have one the kernel mapping. Then you make your temporary mapping
which might be just the one valid TLB entry (after you invalidated the
others). After that you setup multiple mappings to cover 0..2GiB address
space. Since the kernel runs at 0xC.... and you need 0x0.. for the same
memory you end up at some point with two mappings for the same memory.
The reference manual says one should not have two active mappings for
piece of memory. That is why the "other address space" is should be
used.
So I think using this "other address space" for the entry code isn't a
bad idea.

However, I'm fine with this patch.

Sebastian

  parent reply	other threads:[~2011-07-14 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12  6:44 [PATCH v2] powerpc32: Kexec support for PPC440X chipsets Suzuki K. Poulose
2011-07-13  5:28 ` Kumar Gala
2011-07-13  6:01   ` Suzuki Poulose
2011-07-13 11:18   ` Josh Boyer
2011-07-14 15:40 ` Sebastian Andrzej Siewior [this message]
2011-07-18  4:04 ` Suzuki Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110714154042.GA14975@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=suzuki@in.ibm.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).