From: Grant Likely <grant.likely@secretlab.ca>
To: Anatolij Gustschin <agust@denx.de>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/5200: add GPIO functions for simple interrupt GPIOs
Date: Fri, 15 Jul 2011 14:08:01 -0600 [thread overview]
Message-ID: <20110715200801.GJ2833@ponder.secretlab.ca> (raw)
In-Reply-To: <20110709121409.4ee9249e@wker>
On Sat, Jul 09, 2011 at 12:14:09PM +0200, Anatolij Gustschin wrote:
> On Wed, 6 Jul 2011 11:52:45 -0600
> Grant Likely <grant.likely@secretlab.ca> wrote:
>
> > On Mon, May 23, 2011 at 11:25:30AM +0200, Anatolij Gustschin wrote:
> > > The mpc52xx_gpio driver currently supports 8 wakeup GPIOs and 32
> > > simple GPIOs. Extend it to also support GPIO function of 8 simple
> > > interrupt GPIOs controlled in the standard GPIO register module.
> > >
> > > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > > ---
> > > arch/powerpc/platforms/52xx/mpc52xx_gpio.c | 117 ++++++++++++++++++++++++++++
> >
> > I don't want to merge more open coded MMIO gpio driver code. This whole driver really needs to be converted to use GENERIC_GPIO.
>
> I'm not sure I understand what you mean. Do you mean
> the conversion to drop of_mm_* stuff?
No, I mean conversion to use the generic gpio register access
functions instead of creating new ones.
g.
next prev parent reply other threads:[~2011-07-15 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 9:25 [PATCH] powerpc/5200: add GPIO functions for simple interrupt GPIOs Anatolij Gustschin
2011-07-06 9:51 ` Anatolij Gustschin
2011-07-06 17:52 ` Grant Likely
2011-07-09 10:14 ` Anatolij Gustschin
2011-07-15 20:08 ` Grant Likely [this message]
2011-07-19 8:39 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715200801.GJ2833@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).