From: Tony Breeds <tony@bakeyournoodle.com>
To: Ayman Elkhashab <aymane@elkhashab.com>
Cc: Ayman El-Khashab <ayman@elkhashab.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 1/1] powerpc/4xx: enable and fix pcie gen1/gen2 on the 460sx
Date: Mon, 18 Jul 2011 14:01:15 +1000 [thread overview]
Message-ID: <20110718040115.GK20597@ozlabs.org> (raw)
In-Reply-To: <1310748027-31956-1-git-send-email-aymane@elkhashab.com>
On Fri, Jul 15, 2011 at 11:40:27AM -0500, Ayman Elkhashab wrote:
> @@ -1582,8 +1628,8 @@ static int __init ppc4xx_setup_one_pciex_POM(struct ppc4xx_pciex_port *port,
> dcr_write(port->dcrs, DCRO_PEGPL_OMR2BAH, lah);
> dcr_write(port->dcrs, DCRO_PEGPL_OMR2BAL, lal);
> dcr_write(port->dcrs, DCRO_PEGPL_OMR2MSKH, 0x7fffffff);
> - /* Note that 3 here means enabled | single region */
> - dcr_write(port->dcrs, DCRO_PEGPL_OMR2MSKL, sa | 3);
> + dcr_write(port->dcrs, DCRO_PEGPL_OMR2MSKL,
> + sa | DCRO_PEGPL_OMRxMSKL_VAL);
Didn't you just change "sa | 3" to "sa | 1" ?
<snip>
> index 56d9e5d..61b3659 100644
> --- a/arch/powerpc/sysdev/ppc4xx_pci.h
> +++ b/arch/powerpc/sysdev/ppc4xx_pci.h
> @@ -464,6 +464,18 @@
> #define PECFG_POM2LAL 0x390
> #define PECFG_POM2LAH 0x394
>
> +/* 460sx only */
> +#define PECFG_460SX_DLLSTA 0x3f8
> +
> +/* 460sx Bit Mappings */
> +#define PECFG_460SX_DLLSTA_LINKUP 0x00000010
> +#define DCRO_PEGPL_460SX_OMR1MSKL_UOT 0x00000004
> +
> +/* PEGPL Bit Mappings */
> +#define DCRO_PEGPL_OMRxMSKL_VAL 0x00000001
> +#define DCRO_PEGPL_OMR1MSKL_UOT 0x00000002
> +#define DCRO_PEGPL_OMR3MSKL_IO 0x00000002
> +
> /* SDR Bit Mappings */
> #define PESDRx_RCSSET_HLDPLB 0x10000000
> #define PESDRx_RCSSET_RSTGU 0x01000000
Yours Tony
next prev parent reply other threads:[~2011-07-18 4:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 0:33 [PATCH 0/1] powerpc/4xx: enable and fix pcie gen1/gen2 on the 460sx Ayman El-Khashab
2011-07-14 0:33 ` [PATCH 1/1] " Ayman El-Khashab
2011-07-14 1:16 ` Tony Breeds
2011-07-14 16:04 ` Ayman El-Khashab
2011-07-14 22:36 ` Benjamin Herrenschmidt
2011-07-15 16:40 ` [v2 PATCH " Ayman Elkhashab
2011-07-18 4:01 ` Tony Breeds [this message]
2011-07-18 13:31 ` Ayman El-Khashab
2011-07-19 1:23 ` Tony Breeds
2011-07-20 13:02 ` [v3 PATCH 0/1] " Ayman Elkhashab
2011-07-20 13:02 ` [v3 PATCH 1/1] " Ayman Elkhashab
2011-07-21 0:59 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718040115.GK20597@ozlabs.org \
--to=tony@bakeyournoodle.com \
--cc=ayman@elkhashab.com \
--cc=aymane@elkhashab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).