* [PATCH] powerpc: Fix build dependencies for epapr.c which needs libfdt.h
@ 2011-07-19 16:22 Matthew McClintock
2011-07-20 13:49 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Matthew McClintock @ 2011-07-19 16:22 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Matthew McClintock
Currently, the build can (very rarely) fail to build because libfdt.h has
not been created or is in the process of being copied.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
I think this fixes this build error. Please comment as it's really hard to
reproduce this build error. I've seen this happen a few times now on our
automated build server.
BOOTCC arch/powerpc/boot/ep8248e.o
BOOTCC arch/powerpc/boot/cuboot-warp.o
BOOTCC arch/powerpc/boot/cuboot-85xx-cpm2.o
In file included from arch/powerpc/boot/epapr.c:20:0:
arch/powerpc/boot/libfdt.h:382:1: error: unterminated comment
arch/powerpc/boot/libfdt.h:1:0: error: unterminated #ifndef
BOOTCC arch/powerpc/boot/cuboot-yosemite.o
make[1]: *** [arch/powerpc/boot/epapr.o] Error 1
make[1]: *** Waiting for unfinished jobs....
BOOTCC arch/powerpc/boot/simpleboot.o
make: *** [uImage] Error 2
Build step 'Execute shell' marked build as failure
arch/powerpc/boot/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index c26200b..ac6705e 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -58,7 +58,7 @@ $(addprefix $(obj)/,$(zlib) cuboot-c2k.o gunzip_util.o main.o prpmc2800.o): \
libfdt := fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c
libfdtheader := fdt.h libfdt.h libfdt_internal.h
-$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o): \
+$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o epapr.o): \
$(addprefix $(obj)/,$(libfdtheader))
src-wlib := string.S crt0.S crtsavres.S stdio.c main.c \
--
1.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix build dependencies for epapr.c which needs libfdt.h
2011-07-19 16:22 [PATCH] powerpc: Fix build dependencies for epapr.c which needs libfdt.h Matthew McClintock
@ 2011-07-20 13:49 ` David Gibson
2011-09-13 22:43 ` McClintock Matthew-B29882
0 siblings, 1 reply; 3+ messages in thread
From: David Gibson @ 2011-07-20 13:49 UTC (permalink / raw)
To: Matthew McClintock; +Cc: linuxppc-dev
On Tue, Jul 19, 2011 at 11:22:44AM -0500, Matthew McClintock wrote:
> Currently, the build can (very rarely) fail to build because libfdt.h has
> not been created or is in the process of being copied.
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
Looks sane to me.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix build dependencies for epapr.c which needs libfdt.h
2011-07-20 13:49 ` David Gibson
@ 2011-09-13 22:43 ` McClintock Matthew-B29882
0 siblings, 0 replies; 3+ messages in thread
From: McClintock Matthew-B29882 @ 2011-09-13 22:43 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev@lists.ozlabs.org
On Wed, Jul 20, 2011 at 8:49 AM, David Gibson
<david@gibson.dropbear.id.au> wrote:
> On Tue, Jul 19, 2011 at 11:22:44AM -0500, Matthew McClintock wrote:
>> Currently, the build can (very rarely) fail to build because libfdt.h ha=
s
>> not been created or is in the process of being copied.
>>
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>
> Looks sane to me.
ping? I'm still seeing this issue.
-M=
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-13 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-19 16:22 [PATCH] powerpc: Fix build dependencies for epapr.c which needs libfdt.h Matthew McClintock
2011-07-20 13:49 ` David Gibson
2011-09-13 22:43 ` McClintock Matthew-B29882
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).