From: Anton Blanchard <anton@samba.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid
Date: Wed, 10 Aug 2011 21:28:03 +1000 [thread overview]
Message-ID: <20110810212803.143fed4d@kryten> (raw)
In-Reply-To: <20110810183328.cfdfeec82b0d9eb0721687a8@canb.auug.org.au>
Hi Stephen,
> > Index: linux-powerpc/arch/powerpc/mm/numa.c
> > ===================================================================
> > --- linux-powerpc.orig/arch/powerpc/mm/numa.c 2011-06-06
> > 08:07:35.148708089 +1000 +++
> > linux-powerpc/arch/powerpc/mm/numa.c 2011-08-10
> > 11:31:59.723379868 +1000 @@ -1214,7 +1214,6 @@ int
> > hot_add_node_scn_to_nid(unsigned lon break; }
> >
> > - of_node_put(memory);
> > if (nid >= 0)
> > break;
> > }
>
> Won't that need an of_node_put(memory) after the loop if (nid >=
> 0) ? In fact you should be able to just move the of_node_put(memory)
> to after the loop since of_node_put(NULL) is fine.
Nice catch! Will respin the patch.
Anton
prev parent reply other threads:[~2011-08-10 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 6:49 [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid Anton Blanchard
2011-08-10 6:49 ` [PATCH 2/3] powerpc: Use for_each_node_by_type instead of open coding it Anton Blanchard
2011-08-10 6:49 ` [PATCH 3/3] powerpc: Coding style cleanups Anton Blanchard
2011-08-10 8:33 ` [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid Stephen Rothwell
2011-08-10 11:28 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810212803.143fed4d@kryten \
--to=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).