* [PATCH] p1010rdb: gianfar config does not have queues. @ 2011-08-11 14:25 Robin Holt 2012-03-16 15:20 ` Kumar Gala 0 siblings, 1 reply; 4+ messages in thread From: Robin Holt @ 2011-08-11 14:25 UTC (permalink / raw) To: U Bhaskar-B22300; +Cc: PPC list, Eric Dumazet If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties defined in the p1010's device tree file, I get a kernel panic very shortly after boot. The failure indicates we are configuring the gianfar.c driver for a queue depth greater than actual. Removing the properties got the problem resolved. Signed-off-by: Robin Holt <holt@sgi.com> To: U Bhaskar-B22300 <B22300@freescale.com> Cc: PPC list <linuxppc-dev@lists.ozlabs.org> Cc: Eric Dumazet <eric.dumazet@gmail.com> diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi index 7f51104..91566aa 100644 --- a/arch/powerpc/boot/dts/p1010si.dtsi +++ b/arch/powerpc/boot/dts/p1010si.dtsi @@ -258,8 +258,6 @@ device_type = "network"; model = "eTSEC"; compatible = "fsl,etsec2"; - fsl,num_rx_queues = <0x8>; - fsl,num_tx_queues = <0x8>; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>; @@ -280,8 +278,6 @@ device_type = "network"; model = "eTSEC"; compatible = "fsl,etsec2"; - fsl,num_rx_queues = <0x8>; - fsl,num_tx_queues = <0x8>; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>; @@ -302,8 +298,6 @@ device_type = "network"; model = "eTSEC"; compatible = "fsl,etsec2"; - fsl,num_rx_queues = <0x8>; - fsl,num_tx_queues = <0x8>; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>; ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] p1010rdb: gianfar config does not have queues. 2011-08-11 14:25 [PATCH] p1010rdb: gianfar config does not have queues Robin Holt @ 2012-03-16 15:20 ` Kumar Gala 2012-03-17 5:37 ` Aggrwal Poonam-B10812 0 siblings, 1 reply; 4+ messages in thread From: Kumar Gala @ 2012-03-16 15:20 UTC (permalink / raw) To: Aggrwal Poonam-B10812 Cc: PPC list, U Bhaskar-B22300, Robin Holt, Eric Dumazet On Aug 11, 2011, at 9:25 AM, Robin Holt wrote: > If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties > defined in the p1010's device tree file, I get a kernel panic very > shortly after boot. The failure indicates we are configuring the > gianfar.c driver for a queue depth greater than actual. Removing the > properties got the problem resolved. >=20 > Signed-off-by: Robin Holt <holt@sgi.com> > To: U Bhaskar-B22300 <B22300@freescale.com> > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > Cc: Eric Dumazet <eric.dumazet@gmail.com> Poonam, Can you comment on this patch, does it look correct? - k >=20 > diff --git a/arch/powerpc/boot/dts/p1010si.dtsi = b/arch/powerpc/boot/dts/p1010si.dtsi > index 7f51104..91566aa 100644 > --- a/arch/powerpc/boot/dts/p1010si.dtsi > +++ b/arch/powerpc/boot/dts/p1010si.dtsi > @@ -258,8 +258,6 @@ > device_type =3D "network"; > model =3D "eTSEC"; > compatible =3D "fsl,etsec2"; > - fsl,num_rx_queues =3D <0x8>; > - fsl,num_tx_queues =3D <0x8>; > local-mac-address =3D [ 00 00 00 00 00 00 ]; > interrupt-parent =3D <&mpic>; >=20 > @@ -280,8 +278,6 @@ > device_type =3D "network"; > model =3D "eTSEC"; > compatible =3D "fsl,etsec2"; > - fsl,num_rx_queues =3D <0x8>; > - fsl,num_tx_queues =3D <0x8>; > local-mac-address =3D [ 00 00 00 00 00 00 ]; > interrupt-parent =3D <&mpic>; >=20 > @@ -302,8 +298,6 @@ > device_type =3D "network"; > model =3D "eTSEC"; > compatible =3D "fsl,etsec2"; > - fsl,num_rx_queues =3D <0x8>; > - fsl,num_tx_queues =3D <0x8>; > local-mac-address =3D [ 00 00 00 00 00 00 ]; > interrupt-parent =3D <&mpic>; >=20 > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] p1010rdb: gianfar config does not have queues. 2012-03-16 15:20 ` Kumar Gala @ 2012-03-17 5:37 ` Aggrwal Poonam-B10812 2012-03-21 15:26 ` Kumar Gala 0 siblings, 1 reply; 4+ messages in thread From: Aggrwal Poonam-B10812 @ 2012-03-17 5:37 UTC (permalink / raw) To: Kumar Gala, Chauhan Pankaj-B32944, Srivastava Rajan-B34330 Cc: PPC list, U Bhaskar-B22300, Robin Holt, Eric Dumazet Hello Pankaj, Rajan DO you have any comments on the below patch of gianfar? > > - fsl,num_rx_queues =3D <0x8>; > > - fsl,num_tx_queues =3D <0x8>; Have been removed from P1010RDB device tree to avoid a kernel panic. Kumar, as such I see this is the old dts format. Also in the latest sdk tre= e these properties are defined, not sure it is working on P1010RDB. I can check on this and get back. Regards Poonam > -----Original Message----- > From: Kumar Gala [mailto:galak@kernel.crashing.org] > Sent: Friday, March 16, 2012 8:50 PM > To: Aggrwal Poonam-B10812 > Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet > Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues. >=20 >=20 > On Aug 11, 2011, at 9:25 AM, Robin Holt wrote: >=20 > > If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties > > defined in the p1010's device tree file, I get a kernel panic very > > shortly after boot. The failure indicates we are configuring the > > gianfar.c driver for a queue depth greater than actual. Removing the > > properties got the problem resolved. > > > > Signed-off-by: Robin Holt <holt@sgi.com> > > To: U Bhaskar-B22300 <B22300@freescale.com> > > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > > Cc: Eric Dumazet <eric.dumazet@gmail.com> >=20 > Poonam, >=20 > Can you comment on this patch, does it look correct? >=20 > - k >=20 > > > > diff --git a/arch/powerpc/boot/dts/p1010si.dtsi > > b/arch/powerpc/boot/dts/p1010si.dtsi > > index 7f51104..91566aa 100644 > > --- a/arch/powerpc/boot/dts/p1010si.dtsi > > +++ b/arch/powerpc/boot/dts/p1010si.dtsi > > @@ -258,8 +258,6 @@ > > device_type =3D "network"; > > model =3D "eTSEC"; > > compatible =3D "fsl,etsec2"; > > - fsl,num_rx_queues =3D <0x8>; > > - fsl,num_tx_queues =3D <0x8>; > > local-mac-address =3D [ 00 00 00 00 00 00 ]; > > interrupt-parent =3D <&mpic>; > > > > @@ -280,8 +278,6 @@ > > device_type =3D "network"; > > model =3D "eTSEC"; > > compatible =3D "fsl,etsec2"; > > - fsl,num_rx_queues =3D <0x8>; > > - fsl,num_tx_queues =3D <0x8>; > > local-mac-address =3D [ 00 00 00 00 00 00 ]; > > interrupt-parent =3D <&mpic>; > > > > @@ -302,8 +298,6 @@ > > device_type =3D "network"; > > model =3D "eTSEC"; > > compatible =3D "fsl,etsec2"; > > - fsl,num_rx_queues =3D <0x8>; > > - fsl,num_tx_queues =3D <0x8>; > > local-mac-address =3D [ 00 00 00 00 00 00 ]; > > interrupt-parent =3D <&mpic>; > > > > _______________________________________________ > > Linuxppc-dev mailing list > > Linuxppc-dev@lists.ozlabs.org > > https://lists.ozlabs.org/listinfo/linuxppc-dev >=20 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] p1010rdb: gianfar config does not have queues. 2012-03-17 5:37 ` Aggrwal Poonam-B10812 @ 2012-03-21 15:26 ` Kumar Gala 0 siblings, 0 replies; 4+ messages in thread From: Kumar Gala @ 2012-03-21 15:26 UTC (permalink / raw) To: Aggrwal Poonam-B10812 Cc: Chauhan Pankaj-B32944, Eric Dumazet, Srivastava Rajan-B34330, U Bhaskar-B22300, Robin Holt, PPC list On Mar 17, 2012, at 12:37 AM, Aggrwal Poonam-B10812 wrote: > Hello Pankaj, Rajan >=20 > DO you have any comments on the below patch of gianfar? >>> - fsl,num_rx_queues =3D <0x8>; >>> - fsl,num_tx_queues =3D <0x8>; > Have been removed from P1010RDB device tree to avoid a kernel panic. >=20 Ah, right. > Kumar, as such I see this is the old dts format. Also in the latest = sdk tree these properties are defined, not sure it is working on = P1010RDB. > I can check on this and get back. Mostly, can you check that p1010rdb boots and works w/my next branch. - k >=20 >=20 > Regards > Poonam >=20 >> -----Original Message----- >> From: Kumar Gala [mailto:galak@kernel.crashing.org] >> Sent: Friday, March 16, 2012 8:50 PM >> To: Aggrwal Poonam-B10812 >> Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet >> Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues. >>=20 >>=20 >> On Aug 11, 2011, at 9:25 AM, Robin Holt wrote: >>=20 >>> If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties >>> defined in the p1010's device tree file, I get a kernel panic very >>> shortly after boot. The failure indicates we are configuring the >>> gianfar.c driver for a queue depth greater than actual. Removing = the >>> properties got the problem resolved. >>>=20 >>> Signed-off-by: Robin Holt <holt@sgi.com> >>> To: U Bhaskar-B22300 <B22300@freescale.com> >>> Cc: PPC list <linuxppc-dev@lists.ozlabs.org> >>> Cc: Eric Dumazet <eric.dumazet@gmail.com> >>=20 >> Poonam, >>=20 >> Can you comment on this patch, does it look correct? >>=20 >> - k >>=20 >>>=20 >>> diff --git a/arch/powerpc/boot/dts/p1010si.dtsi >>> b/arch/powerpc/boot/dts/p1010si.dtsi >>> index 7f51104..91566aa 100644 >>> --- a/arch/powerpc/boot/dts/p1010si.dtsi >>> +++ b/arch/powerpc/boot/dts/p1010si.dtsi >>> @@ -258,8 +258,6 @@ >>> device_type =3D "network"; >>> model =3D "eTSEC"; >>> compatible =3D "fsl,etsec2"; >>> - fsl,num_rx_queues =3D <0x8>; >>> - fsl,num_tx_queues =3D <0x8>; >>> local-mac-address =3D [ 00 00 00 00 00 00 ]; >>> interrupt-parent =3D <&mpic>; >>>=20 >>> @@ -280,8 +278,6 @@ >>> device_type =3D "network"; >>> model =3D "eTSEC"; >>> compatible =3D "fsl,etsec2"; >>> - fsl,num_rx_queues =3D <0x8>; >>> - fsl,num_tx_queues =3D <0x8>; >>> local-mac-address =3D [ 00 00 00 00 00 00 ]; >>> interrupt-parent =3D <&mpic>; >>>=20 >>> @@ -302,8 +298,6 @@ >>> device_type =3D "network"; >>> model =3D "eTSEC"; >>> compatible =3D "fsl,etsec2"; >>> - fsl,num_rx_queues =3D <0x8>; >>> - fsl,num_tx_queues =3D <0x8>; >>> local-mac-address =3D [ 00 00 00 00 00 00 ]; >>> interrupt-parent =3D <&mpic>; >>>=20 >>> _______________________________________________ >>> Linuxppc-dev mailing list >>> Linuxppc-dev@lists.ozlabs.org >>> https://lists.ozlabs.org/listinfo/linuxppc-dev >>=20 >=20 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-21 15:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-08-11 14:25 [PATCH] p1010rdb: gianfar config does not have queues Robin Holt 2012-03-16 15:20 ` Kumar Gala 2012-03-17 5:37 ` Aggrwal Poonam-B10812 2012-03-21 15:26 ` Kumar Gala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).