From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Pratyush Anand <pratyush.anand@st.com>
Cc: viresh.kumar@st.com, vipulkumar.samar@st.com,
bhupesh.sharma@st.com, tmarri@apm.com, linux-usb@vger.kernel.org,
vipin.kumar@st.com, shiraz.hashim@st.com, Amit.VIRDI@st.com,
rajeev-dlh.kumar@st.com, mmiesfeld@apm.com, deepak.sikri@st.com,
linuxppc-dev@lists.ozlabs.org, fchen@apm.com
Subject: Re: [PATCH 08/14] dwc/otg: Add PCD function
Date: Wed, 31 Aug 2011 09:44:18 +0200 [thread overview]
Message-ID: <20110831074418.GC9353@linutronix.de> (raw)
In-Reply-To: <1b982bbcef0019d506c79ab90621ffe7744751b4.1314704558.git.pratyush.anand@st.com>
* Pratyush Anand | 2011-08-30 17:27:55 [+0530]:
>diff --git a/drivers/usb/dwc/pcd.c b/drivers/usb/dwc/pcd.c
>new file mode 100644
>index 0000000..2ef6405
>--- /dev/null
>+++ b/drivers/usb/dwc/pcd.c
>+static const struct usb_gadget_ops dwc_otg_pcd_ops = {
>+ .get_frame = dwc_otg_pcd_get_frame,
>+ .wakeup = dwc_otg_pcd_wakeup,
You may want to provide udc_start and udc_stop hooks.
drivers/usb/dwc3/gadget.c and drivers/usb/musb/musb_gadget.c are two
driver which are using it. The other gadget are using .start and .stop
hooks which I would like to go.
>+ /* not selfpowered */
>+};
>+
>+/**
>+ * This function registers a gadget driver with the PCD.
>+ *
>+ * When a driver is successfully registered, it will receive control
>+ * requests including set_configuration(), which enables non-control
>+ * requests. then usb traffic follows until a disconnect is reported.
>+ * then a host may connect again, or the driver might get unbound.
>+ */
>+int usb_gadget_probe_driver(struct usb_gadget_driver *driver,
>+ int (*bind) (struct usb_gadget *))
You can not provide usb_gadget_probe_driver() anymore. That is why you
need to provide those hooks I mentioned.
Sebastian
next prev parent reply other threads:[~2011-08-31 7:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 11:57 [PATCH 00/14] Modifications for DWC OTG since v13 Pratyush Anand
2011-08-30 11:57 ` [PATCH 01/14] dwc/otg: Add Register definitions Pratyush Anand
2011-08-31 22:35 ` Greg KH
2011-09-02 11:31 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 02/14] dwc/otg: Structure declaration for shared data Pratyush Anand
2011-08-30 15:29 ` Tirumala Marri
2011-08-30 15:43 ` Pratyush Anand
2011-08-31 17:17 ` Tirumala Marri
2011-09-02 11:42 ` Pratyush Anand
2011-09-02 12:30 ` Alexander Gordeev
2011-09-02 16:40 ` Tirumala Marri
2011-09-02 16:37 ` Tirumala Marri
2011-08-31 22:36 ` Greg KH
2011-09-01 0:18 ` Josh Boyer
2011-09-01 1:37 ` Greg KH
2011-08-31 22:36 ` Greg KH
2011-09-02 11:49 ` Pratyush Anand
2011-09-02 13:57 ` Greg KH
2011-08-30 11:57 ` [PATCH 03/14] dwc/otg: Add driver framework Pratyush Anand
2011-08-31 7:19 ` Sebastian Andrzej Siewior
2011-09-02 11:17 ` Pratyush Anand
2011-09-02 11:32 ` Sebastian Andrzej Siewior
2011-09-02 11:55 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 04/14] dwc/otg: Add Core Interface Layer (CIL) Pratyush Anand
2011-08-30 11:57 ` [PATCH 05/14] dwc/otg: Add HCD function Pratyush Anand
2011-08-30 11:57 ` [PATCH 06/14] dwc/otg: Add HCD interrupt function Pratyush Anand
2011-08-30 11:57 ` [PATCH 07/14] dwc/otg: Add HCD queue function Pratyush Anand
2011-08-30 11:57 ` [PATCH 08/14] dwc/otg: Add PCD function Pratyush Anand
2011-08-31 7:44 ` Sebastian Andrzej Siewior [this message]
2011-09-02 11:26 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 09/14] dwc/otg: Add PCD interrupt function Pratyush Anand
2011-08-30 11:57 ` [PATCH 10/14] dwc/otg: Add driver kernel configuration and Makefile Pratyush Anand
2011-08-30 11:57 ` [PATCH 11/14] dwc/otg: Driver enable gadget support Pratyush Anand
2011-08-30 13:01 ` Sergei Shtylyov
2011-08-30 15:40 ` Pratyush Anand
2011-08-30 11:57 ` [PATCH 12/14] include/linux/usb/gadget.h : include <linux/device.h> for successful compilation Pratyush Anand
2011-08-30 12:57 ` Sergei Shtylyov
2011-08-30 11:58 ` [PATCH 13/14] usb/gadget/kconfig: added dwc otg as an option for peripheral controller Pratyush Anand
2011-08-30 11:58 ` [PATCH 14/14] arm/include/asm/io.h : added macros to read/write big/little endian register Pratyush Anand
2011-08-31 7:35 ` Sebastian Andrzej Siewior
2011-09-02 10:43 ` Pratyush Anand
2011-09-02 11:02 ` Benjamin Herrenschmidt
2011-09-02 11:01 ` Benjamin Herrenschmidt
2011-09-05 14:28 ` Sebastian Andrzej Siewior
2011-09-05 17:16 ` Benjamin Herrenschmidt
2011-08-30 15:27 ` [PATCH 00/14] Modifications for DWC OTG since v13 Tirumala Marri
2011-08-30 15:46 ` Pratyush Anand
2011-08-31 1:18 ` Kyungmin Park
2011-08-31 6:49 ` Alexander Gordeev
2011-08-31 7:03 ` Pratyush Anand
2011-08-31 20:33 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831074418.GC9353@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Amit.VIRDI@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=fchen@apm.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmiesfeld@apm.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=tmarri@apm.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).