From: David Miller <davem@davemloft.net>
To: tglx@linutronix.de
Cc: perex@perex.cz, dhowells@redhat.com, prakity@marvell.com,
netdev@vger.kernel.org, chunkeey@googlemail.com,
sonic.zhang@analog.com, klaus.kudielka@ieee.org,
t.sailer@alumni.ethz.ch, khilman@ti.com, eric.dumazet@gmail.com,
jhovold@gmail.com, cyril@ti.com, rmk+kernel@arm.linux.org.uk,
mingo@elte.hu, jpr@f6fbb.org, adobriyan@gmail.com,
jreuter@yaina.de, cbe-oss-dev@lists.ozlabs.org,
martinez.javier@gmail.com, samuel@sortiz.org, vapier@gentoo.org,
grundler@parisc-linux.org, yong.zhang0@gmail.com,
tklauser@distanz.ch, lucas.demarchi@profusion.mobi,
u.kleine-koenig@pengutronix.de, olof@lixom.net,
uclinux-dist-devel@blackfin.uclinux.org,
linux-hams@vger.kernel.org, leitao@linux.vnet.ibm.com,
blogic@openwrt.org, shawn.guo@linaro.org, nico@fluxnic.net,
geoff@infradead.org, jkosina@suse.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, ralph.hempel@lantiq.com, jdmason@kudzu.us,
joe@perches.com, steve.glendinning@smsc.com,
richard.cochran@omicron.at, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED
Date: Wed, 07 Sep 2011 13:52:34 -0400 (EDT) [thread overview]
Message-ID: <20110907.135234.17759197083710999.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.02.1109071932100.2723@ionos>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST)
> On Wed, 7 Sep 2011, David Miller wrote:
>
>> From: Yong Zhang <yong.zhang0@gmail.com>
>> Date: Wed, 7 Sep 2011 16:10:42 +0800
>>
>> > This flag is a NOOP and can be removed now.
>> >
>> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
>>
>> I have the same concerns here as I had for the sparc case.
>>
>> Some of these drivers might be using IRQF_DISABLED to make sure the
>> IRQ cannot be delivered until it is explicitly enabled via an
>> enable_irq() call.
>>
>> How is that being accomodated now?
>
> Again IRQF_DISABLED never ever had that functionality.
My bad.
But what if these interrupts want interrupts disabled during their
interrupt handler, for other reasons?
This has the potential to break tons of stuff, especially on the
really old chips which almost no developers have any more but some
user might try to use.
next prev parent reply other threads:[~2011-09-07 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com>
2011-09-07 8:10 ` [PATCH 17/62] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-08 16:41 ` Arnd Bergmann
2011-09-07 8:10 ` [PATCH 45/62] net: " Yong Zhang
2011-09-07 17:13 ` David Miller
2011-09-07 17:32 ` Thomas Gleixner
2011-09-07 17:52 ` David Miller [this message]
2011-09-07 18:03 ` Thomas Gleixner
2011-09-08 13:41 ` Yong Zhang
2011-09-07 8:10 ` [PATCH 51/62] powerpc/ps3: " Yong Zhang
2011-09-07 17:04 ` Geoff Levand
2011-09-07 8:10 ` [PATCH 54/62] TTY: " Yong Zhang
2011-09-09 9:49 ` Tobias Klauser
2011-09-22 23:04 ` Greg KH
2011-09-22 23:08 ` Greg KH
2011-09-07 8:10 ` [PATCH 55/62] USB: " Yong Zhang
2011-09-07 8:10 ` [PATCH 56/62] video: " Yong Zhang
2011-09-07 8:10 ` [PATCH 60/62] sound: " Yong Zhang
2011-09-07 8:36 ` Péter Ujfalusi
2011-09-07 17:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907.135234.17759197083710999.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=blogic@openwrt.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=chunkeey@googlemail.com \
--cc=cyril@ti.com \
--cc=dhowells@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=geoff@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=jdmason@kudzu.us \
--cc=jhovold@gmail.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=jpr@f6fbb.org \
--cc=jreuter@yaina.de \
--cc=khilman@ti.com \
--cc=klaus.kudielka@ieee.org \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=martinez.javier@gmail.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=olof@lixom.net \
--cc=perex@perex.cz \
--cc=prakity@marvell.com \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
--cc=richard.cochran@omicron.at \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=samuel@sortiz.org \
--cc=shawn.guo@linaro.org \
--cc=sonic.zhang@analog.com \
--cc=steve.glendinning@smsc.com \
--cc=t.sailer@alumni.ethz.ch \
--cc=tglx@linutronix.de \
--cc=tklauser@distanz.ch \
--cc=u.kleine-koenig@pengutronix.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).