From: Anatolij Gustschin <agust@denx.de>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] fsl-diu-fb: remove the ioctl interface
Date: Wed, 21 Sep 2011 10:29:54 +0200 [thread overview]
Message-ID: <20110921102954.151d7cde@wker> (raw)
In-Reply-To: <CAOZdJXUZsByLorWZNtDRMzsezF_qVX62+8zfiMKJqMMhCD2i3g@mail.gmail.com>
On Wed, 21 Sep 2011 02:10:42 +0000
Tabi Timur-B04825 <B04825@freescale.com> wrote:
...
> The definitions of MFB_SET_PIXFMT and MFB_GET_PIXFMT are wrong:
>
> #define MFB_SET_PIXFMT 0x80014d08
> #define MFB_GET_PIXFMT 0x40014d08
>
> The "01" is the size. However, these ioctls take a __u32 as a parameter.
>
> This means that I have to fix the definitions to this:
>
> #define MFB_SET_PIXFMT _IOW('M', 8, __u32)
> #define MFB_GET_PIXFMT _IOR('M', 8, __u32)
>
> This will change the values and break binary compatibility with your
> applications. Are you okay with that?
yes. the app will be fixed for updated kernel.
> > Other ioctls can be removed. I'm not sure if someone
> > uses FBIOGET_GWINFO. If there are no objections from
> > other people, it can also be dropped.
>
> I'm going to remove FBIOGET_GWINFO because no one is using it, and the
> ioctl value is malformed (it doesn't define a direction or size).
okay.
Thanks,
Anatolij
next prev parent reply other threads:[~2011-09-21 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 21:27 [PATCH] fsl-diu-fb: remove the ioctl interface Timur Tabi
2011-06-21 22:38 ` Anatolij Gustschin
2011-06-21 23:13 ` Tabi Timur-B04825
2011-06-22 20:11 ` Anatolij Gustschin
2011-09-21 2:10 ` Tabi Timur-B04825
2011-09-21 8:29 ` Anatolij Gustschin [this message]
2011-06-22 10:39 ` Jenkins, Clive
2011-06-23 11:26 ` Anatolij Gustschin
2011-06-23 11:29 ` Tabi Timur-B04825
2011-06-23 11:39 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921102954.151d7cde@wker \
--to=agust@denx.de \
--cc=B04825@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).