From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH V2 1/2] gpio: move mpc8xxx/512x gpio driver to drivers/gpio
Date: Wed, 21 Sep 2011 10:33:01 -0600 [thread overview]
Message-ID: <20110921163301.GZ7781@ponder.secretlab.ca> (raw)
In-Reply-To: <1316602161-12546-1-git-send-email-w.sang@pengutronix.de>
On Wed, Sep 21, 2011 at 12:49:20PM +0200, Wolfram Sang wrote:
> Move the driver to the place where it is expected to be nowadays. Also
> rename its CONFIG-name to match the rest and adapt the defconfigs.
> Finally, move selection of REQUIRE_GPIOLIB or WANTS_OPTIONAL_GPIOLIB to
> the platforms, because this option is per-platform and not per-driver.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> I'd think this should go via ppc, so it is in sync with the defconfig update of
> patch 2/2.
>
> Changes since V1: Use -C in format-patch to show the rename.
Nit: I prefer to see the changelog before the s-o-b lines so that it
gets included in the final commit text. Helps when trying to identify
exactly which version of a patch got merged.
>
> arch/powerpc/configs/85xx/p1023rds_defconfig | 2 +-
> arch/powerpc/configs/85xx/xes_mpc85xx_defconfig | 2 +-
> arch/powerpc/configs/mpc85xx_defconfig | 2 +-
> arch/powerpc/configs/mpc85xx_smp_defconfig | 2 +-
> arch/powerpc/configs/ppc6xx_defconfig | 2 +-
> arch/powerpc/platforms/512x/Kconfig | 1 +
> arch/powerpc/platforms/83xx/Kconfig | 9 ++++++---
> arch/powerpc/platforms/85xx/Kconfig | 12 ++++++++----
> arch/powerpc/platforms/86xx/Kconfig | 1 +
> arch/powerpc/platforms/Kconfig | 10 ----------
> arch/powerpc/sysdev/Makefile | 1 -
> drivers/gpio/Kconfig | 8 ++++++++
> drivers/gpio/Makefile | 1 +
> .../mpc8xxx_gpio.c => drivers/gpio/gpio-mpc8xxx.c | 0
> 14 files changed, 30 insertions(+), 23 deletions(-)
> rename arch/powerpc/sysdev/mpc8xxx_gpio.c => drivers/gpio/gpio-mpc8xxx.c (100%)
Looks good to me. Acked-by: Grant Likely <grant.likely@secretlab.ca>
Yes, it probably should go via the ppc tree. I don't foresee any conflict
issues with the gpio tree.
g.
next prev parent reply other threads:[~2011-09-21 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 10:49 [PATCH V2 1/2] gpio: move mpc8xxx/512x gpio driver to drivers/gpio Wolfram Sang
2011-09-21 10:49 ` [PATCH V2 2/2] powerpc: update 512x-defconfig Wolfram Sang
2011-09-21 16:33 ` Grant Likely [this message]
2011-09-22 23:03 ` [PATCH V2 1/2] gpio: move mpc8xxx/512x gpio driver to drivers/gpio Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921163301.GZ7781@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).