[PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

From: Kai Jiang <Kai.Jiang@freescale.com>

To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
extend the width of 'addr' in struct uio_mem.  Numerous platforms like
embedded PPC, ARM, and X86 have support for systems with larger physical
address than logical.

Since 'addr' may contain a physical, logical, or virtual address the
easiest solution is to just change the type to 'phys_addr_t' which
should always be greater than or equal to the sizeof(void *) such that
it can properly hold any of the address types.

For physical address we can support up to a 44-bit physical address on a
typical 32-bit system as we utilize remap_pfn_range() for the mapping of
the memory region and pfn's are represnted by shifting the address by
the page size (typically 4k).

Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
v3:
* Updated commit message to be correct w/regards to code
* Updated comment about addr field in uio_mem
v2:
* Use phys_addr_t instead of 'unsigned long long'
* Updated DocBook detail in uio-howto.tmpl

 Documentation/DocBook/uio-howto.tmpl |    2 +-
 drivers/uio/uio.c                    |    8 ++++----
 include/linux/uio_driver.h           |    7 +++++--
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/Documentation/DocBook/uio-howto.tmpl b/Documentation/DocBook/uio-howto.tmpl
index 7c4b514d..54883de 100644
--- a/Documentation/DocBook/uio-howto.tmpl
+++ b/Documentation/DocBook/uio-howto.tmpl
@@ -529,7 +529,7 @@ memory (e.g. allocated with <function>kmalloc()</function>). There's also
 </para></listitem>
 
 <listitem><para>
-<varname>unsigned long addr</varname>: Required if the mapping is used.
+<varname>phys_addr_t addr</varname>: Required if the mapping is used.
 Fill in the address of your memory block. This address is the one that
 appears in sysfs.
 </para></listitem>
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 88f4444..43b7096 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr);
 }
 
 static ssize_t map_size_show(struct uio_mem *mem, char *buf)
@@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr & ~PAGE_MASK);
 }
 
 struct map_sysfs_entry {
@@ -634,8 +634,8 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
 		page = virt_to_page(idev->info->mem[mi].addr + offset);
 	else
-		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
-							+ offset);
+		page = vmalloc_to_page((void *)(unsigned long)
+				idev->info->mem[mi].addr + offset);
 	get_page(page);
 	vmf->page = page;
 	return 0;
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index 4c618cd..ad16aa9 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -23,7 +23,10 @@ struct uio_map;
 /**
  * struct uio_mem - description of a UIO memory region
  * @name:		name of the memory region for identification
- * @addr:		address of the device's memory
+ * @addr:		address of the device's memory (phys_addr is used since
+ * 			addr can be logical, virtual, or physical & phys_addr_t
+ * 			should always be large enough to handle any of the
+ * 			address types)
  * @size:		size of IO
  * @memtype:		type of memory addr points to
  * @internal_addr:	ioremap-ped version of addr, for driver internal use
@@ -32,7 +35,7 @@ struct uio_map;
  */
 struct uio_mem {
 	const char		*name;
-	unsigned long		addr;
+	phys_addr_t		addr;
 	unsigned long		size;
 	int			memtype;
 	void __iomem		*internal_addr;
-- 
1.7.3.4

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> From: Kai Jiang <Kai.Jiang@freescale.com>
> 
> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> embedded PPC, ARM, and X86 have support for systems with larger physical
> address than logical.
> 
> Since 'addr' may contain a physical, logical, or virtual address the
> easiest solution is to just change the type to 'phys_addr_t' which
> should always be greater than or equal to the sizeof(void *) such that
> it can properly hold any of the address types.
> 
> For physical address we can support up to a 44-bit physical address on a
> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> the memory region and pfn's are represnted by shifting the address by
> the page size (typically 4k).
> 
> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>

That looks good to me. There's an unnecessary cast (see below), but I fixed that
on the way.

Greg, please pull this from branch uio-for-gregkh from

git://hansjkoch.de/git/linux-hjk

Thanks,
Hans

> ---
> v3:
> * Updated commit message to be correct w/regards to code
> * Updated comment about addr field in uio_mem
> v2:
> * Use phys_addr_t instead of 'unsigned long long'
> * Updated DocBook detail in uio-howto.tmpl
> 
>  Documentation/DocBook/uio-howto.tmpl |    2 +-
>  drivers/uio/uio.c                    |    8 ++++----
>  include/linux/uio_driver.h           |    7 +++++--
>  3 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/DocBook/uio-howto.tmpl b/Documentation/DocBook/uio-howto.tmpl
> index 7c4b514d..54883de 100644
> --- a/Documentation/DocBook/uio-howto.tmpl
> +++ b/Documentation/DocBook/uio-howto.tmpl
> @@ -529,7 +529,7 @@ memory (e.g. allocated with <function>kmalloc()</function>). There's also
>  </para></listitem>
>  
>  <listitem><para>
> -<varname>unsigned long addr</varname>: Required if the mapping is used.
> +<varname>phys_addr_t addr</varname>: Required if the mapping is used.
>  Fill in the address of your memory block. This address is the one that
>  appears in sysfs.
>  </para></listitem>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 88f4444..43b7096 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
>  
>  static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
>  {
> -	return sprintf(buf, "0x%lx\n", mem->addr);
> +	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr);
>  }
>  
>  static ssize_t map_size_show(struct uio_mem *mem, char *buf)
> @@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
>  
>  static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
>  {
> -	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
> +	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr & ~PAGE_MASK);
>  }
>  
>  struct map_sysfs_entry {
> @@ -634,8 +634,8 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
>  	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
>  		page = virt_to_page(idev->info->mem[mi].addr + offset);
>  	else
> -		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
> -							+ offset);
> +		page = vmalloc_to_page((void *)(unsigned long)

(void *) is enough, the (unsigned long) is not needed.

> +				idev->info->mem[mi].addr + offset);
>  	get_page(page);
>  	vmf->page = page;
>  	return 0;
> diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
> index 4c618cd..ad16aa9 100644
> --- a/include/linux/uio_driver.h
> +++ b/include/linux/uio_driver.h
> @@ -23,7 +23,10 @@ struct uio_map;
>  /**
>   * struct uio_mem - description of a UIO memory region
>   * @name:		name of the memory region for identification
> - * @addr:		address of the device's memory
> + * @addr:		address of the device's memory (phys_addr is used since
> + * 			addr can be logical, virtual, or physical & phys_addr_t
> + * 			should always be large enough to handle any of the
> + * 			address types)
>   * @size:		size of IO
>   * @memtype:		type of memory addr points to
>   * @internal_addr:	ioremap-ped version of addr, for driver internal use
> @@ -32,7 +35,7 @@ struct uio_map;
>   */
>  struct uio_mem {
>  	const char		*name;
> -	unsigned long		addr;
> +	phys_addr_t		addr;
>  	unsigned long		size;
>  	int			memtype;
>  	void __iomem		*internal_addr;
> -- 
> 1.7.3.4
> 
> 

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Greg KH]

On Fri, Oct 14, 2011 at 08:31:45PM +0200, Hans J. Koch wrote:
> On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> > From: Kai Jiang <Kai.Jiang@freescale.com>
> > 
> > To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > embedded PPC, ARM, and X86 have support for systems with larger physical
> > address than logical.
> > 
> > Since 'addr' may contain a physical, logical, or virtual address the
> > easiest solution is to just change the type to 'phys_addr_t' which
> > should always be greater than or equal to the sizeof(void *) such that
> > it can properly hold any of the address types.
> > 
> > For physical address we can support up to a 44-bit physical address on a
> > typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> > the memory region and pfn's are represnted by shifting the address by
> > the page size (typically 4k).
> > 
> > Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> 
> Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> 
> That looks good to me. There's an unnecessary cast (see below), but I fixed that
> on the way.
> 
> Greg, please pull this from branch uio-for-gregkh from
> 
> git://hansjkoch.de/git/linux-hjk

Care to send it as an email?  I can apply it easier that way as I have
limited internet access while on the road.

greg k-h

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Fri, Oct 14, 2011 at 12:36:33PM -0600, Greg KH wrote:
> On Fri, Oct 14, 2011 at 08:31:45PM +0200, Hans J. Koch wrote:
> > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> > > From: Kai Jiang <Kai.Jiang@freescale.com>
> > > 
> > > To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > > extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > > embedded PPC, ARM, and X86 have support for systems with larger physical
> > > address than logical.
> > > 
> > > Since 'addr' may contain a physical, logical, or virtual address the
> > > easiest solution is to just change the type to 'phys_addr_t' which
> > > should always be greater than or equal to the sizeof(void *) such that
> > > it can properly hold any of the address types.
> > > 
> > > For physical address we can support up to a 44-bit physical address on a
> > > typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> > > the memory region and pfn's are represnted by shifting the address by
> > > the page size (typically 4k).
> > > 
> > > Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > 
> > Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> > 
> > That looks good to me. There's an unnecessary cast (see below), but I fixed that
> > on the way.
> > 
> > Greg, please pull this from branch uio-for-gregkh from
> > 
> > git://hansjkoch.de/git/linux-hjk
> 
> Care to send it as an email?  I can apply it easier that way as I have
> limited internet access while on the road.
> 
> greg k-h


>From b00f4ca33322a48928624ae3c34dc5fe9d2f40ff Mon Sep 17 00:00:00 2001
From: Kai Jiang <Kai.Jiang@freescale.com>
Date: Fri, 14 Oct 2011 20:04:43 +0200
Subject: [PATCH] uio: Support physical addresses >32 bits on 32-bit systems

From: Kai Jiang <Kai.Jiang@freescale.com>

To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
extend the width of 'addr' in struct uio_mem.  Numerous platforms like
embedded PPC, ARM, and X86 have support for systems with larger physical
address than logical.

Since 'addr' may contain a physical, logical, or virtual address the
easiest solution is to just change the type to 'phys_addr_t' which
should always be greater than or equal to the sizeof(void *) such that
it can properly hold any of the address types.

For physical address we can support up to a 44-bit physical address on a
typical 32-bit system as we utilize remap_pfn_range() for the mapping of
the memory region and pfn's are represnted by shifting the address by
the page size (typically 4k).

Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Hans J. Koch <hjk@hansjkoch.de>
---
 Documentation/DocBook/uio-howto.tmpl |    2 +-
 drivers/uio/uio.c                    |    7 +++----
 include/linux/uio_driver.h           |    7 +++++--
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/Documentation/DocBook/uio-howto.tmpl b/Documentation/DocBook/uio-howto.tmpl
index 7c4b514d..54883de 100644
--- a/Documentation/DocBook/uio-howto.tmpl
+++ b/Documentation/DocBook/uio-howto.tmpl
@@ -529,7 +529,7 @@ memory (e.g. allocated with <function>kmalloc()</function>). There's also
 </para></listitem>
 
 <listitem><para>
-<varname>unsigned long addr</varname>: Required if the mapping is used.
+<varname>phys_addr_t addr</varname>: Required if the mapping is used.
 Fill in the address of your memory block. This address is the one that
 appears in sysfs.
 </para></listitem>
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index d2efe82..c0626ea 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr);
 }
 
 static ssize_t map_size_show(struct uio_mem *mem, char *buf)
@@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr & ~PAGE_MASK);
 }
 
 struct map_sysfs_entry {
@@ -634,8 +634,7 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
 		page = virt_to_page(idev->info->mem[mi].addr + offset);
 	else
-		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
-							+ offset);
+		page = vmalloc_to_page((void *)idev->info->mem[mi].addr + offset);
 	get_page(page);
 	vmf->page = page;
 	return 0;
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index 665517c..fd99ff9 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -23,7 +23,10 @@ struct uio_map;
 /**
  * struct uio_mem - description of a UIO memory region
  * @name:		name of the memory region for identification
- * @addr:		address of the device's memory
+ * @addr:		address of the device's memory (phys_addr is used since
+ * 			addr can be logical, virtual, or physical & phys_addr_t
+ * 			should always be large enough to handle any of the
+ * 			address types)
  * @size:		size of IO
  * @memtype:		type of memory addr points to
  * @internal_addr:	ioremap-ped version of addr, for driver internal use
@@ -31,7 +34,7 @@ struct uio_map;
  */
 struct uio_mem {
 	const char		*name;
-	unsigned long		addr;
+	phys_addr_t		addr;
 	unsigned long		size;
 	int			memtype;
 	void __iomem		*internal_addr;
-- 
1.7.6.3

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:

> On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>=20
>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need =
to
>> extend the width of 'addr' in struct uio_mem.  Numerous platforms =
like
>> embedded PPC, ARM, and X86 have support for systems with larger =
physical
>> address than logical.
>>=20
>> Since 'addr' may contain a physical, logical, or virtual address the
>> easiest solution is to just change the type to 'phys_addr_t' which
>> should always be greater than or equal to the sizeof(void *) such =
that
>> it can properly hold any of the address types.
>>=20
>> For physical address we can support up to a 44-bit physical address =
on a
>> typical 32-bit system as we utilize remap_pfn_range() for the mapping =
of
>> the memory region and pfn's are represnted by shifting the address by
>> the page size (typically 4k).
>>=20
>> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>=20
> Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
>=20
> That looks good to me. There's an unnecessary cast (see below), but I =
fixed that
> on the way.
>=20
> Greg, please pull this from branch uio-for-gregkh from
>=20
> git://hansjkoch.de/git/linux-hjk
>=20
> Thanks,
> Hans

I think removing that cast is wrong:

drivers/uio/uio.c: In function 'uio_vma_fault':
drivers/uio/uio.c:637:26: warning: cast to pointer from integer of =
different size

- k

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Mon, Oct 17, 2011 at 11:00:55AM -0500, Kumar Gala wrote:
> 
> On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:
> 
> > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> >> From: Kai Jiang <Kai.Jiang@freescale.com>
> >> 
> >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> >> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> >> embedded PPC, ARM, and X86 have support for systems with larger physical
> >> address than logical.
> >> 
> >> Since 'addr' may contain a physical, logical, or virtual address the
> >> easiest solution is to just change the type to 'phys_addr_t' which
> >> should always be greater than or equal to the sizeof(void *) such that
> >> it can properly hold any of the address types.
> >> 
> >> For physical address we can support up to a 44-bit physical address on a
> >> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> >> the memory region and pfn's are represnted by shifting the address by
> >> the page size (typically 4k).
> >> 
> >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> >> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > 
> > Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> > 
> > That looks good to me. There's an unnecessary cast (see below), but I fixed that
> > on the way.
> > 
> > Greg, please pull this from branch uio-for-gregkh from
> > 
> > git://hansjkoch.de/git/linux-hjk
> > 
> > Thanks,
> > Hans
> 
> I think removing that cast is wrong:
> 
> drivers/uio/uio.c: In function 'uio_vma_fault':
> drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size

Hmm, on what platform did you see this? I tested on 32bit-x86 and didn't get
any warnings.

Hans

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Mon, Oct 17, 2011 at 07:18:59PM +0200, Hans J. Koch wrote:
> On Mon, Oct 17, 2011 at 11:00:55AM -0500, Kumar Gala wrote:
> > 
> > On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:
> > 
> > > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> > >> From: Kai Jiang <Kai.Jiang@freescale.com>
> > >> 
> > >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > >> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > >> embedded PPC, ARM, and X86 have support for systems with larger physical
> > >> address than logical.
> > >> 
> > >> Since 'addr' may contain a physical, logical, or virtual address the
> > >> easiest solution is to just change the type to 'phys_addr_t' which
> > >> should always be greater than or equal to the sizeof(void *) such that
> > >> it can properly hold any of the address types.
> > >> 
> > >> For physical address we can support up to a 44-bit physical address on a
> > >> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> > >> the memory region and pfn's are represnted by shifting the address by
> > >> the page size (typically 4k).
> > >> 
> > >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> > >> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > > 
> > > Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> > > 
> > > That looks good to me. There's an unnecessary cast (see below), but I fixed that
> > > on the way.
> > > 
> > > Greg, please pull this from branch uio-for-gregkh from
> > > 
> > > git://hansjkoch.de/git/linux-hjk
> > > 
> > > Thanks,
> > > Hans
> > 
> > I think removing that cast is wrong:
> > 
> > drivers/uio/uio.c: In function 'uio_vma_fault':
> > drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size
> 
> Hmm, on what platform did you see this? I tested on 32bit-x86 and didn't get
> any warnings.

OK, you're right. I turned on CONFIG_HIGHMEM64G and got that warning. Damned x86...

Greg, can you fix it, or should I send the patch again?

Thanks,
Hans

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Greg KH]

On Mon, Oct 17, 2011 at 08:03:51PM +0200, Hans J. Koch wrote:
> On Mon, Oct 17, 2011 at 07:18:59PM +0200, Hans J. Koch wrote:
> > On Mon, Oct 17, 2011 at 11:00:55AM -0500, Kumar Gala wrote:
> > > 
> > > On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:
> > > 
> > > > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> > > >> From: Kai Jiang <Kai.Jiang@freescale.com>
> > > >> 
> > > >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > > >> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > > >> embedded PPC, ARM, and X86 have support for systems with larger physical
> > > >> address than logical.
> > > >> 
> > > >> Since 'addr' may contain a physical, logical, or virtual address the
> > > >> easiest solution is to just change the type to 'phys_addr_t' which
> > > >> should always be greater than or equal to the sizeof(void *) such that
> > > >> it can properly hold any of the address types.
> > > >> 
> > > >> For physical address we can support up to a 44-bit physical address on a
> > > >> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> > > >> the memory region and pfn's are represnted by shifting the address by
> > > >> the page size (typically 4k).
> > > >> 
> > > >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> > > >> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > > >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > > > 
> > > > Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> > > > 
> > > > That looks good to me. There's an unnecessary cast (see below), but I fixed that
> > > > on the way.
> > > > 
> > > > Greg, please pull this from branch uio-for-gregkh from
> > > > 
> > > > git://hansjkoch.de/git/linux-hjk
> > > > 
> > > > Thanks,
> > > > Hans
> > > 
> > > I think removing that cast is wrong:
> > > 
> > > drivers/uio/uio.c: In function 'uio_vma_fault':
> > > drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size
> > 
> > Hmm, on what platform did you see this? I tested on 32bit-x86 and didn't get
> > any warnings.
> 
> OK, you're right. I turned on CONFIG_HIGHMEM64G and got that warning. Damned x86...
> 
> Greg, can you fix it, or should I send the patch again?

Please send it again.

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Mon, Oct 17, 2011 at 11:23:45AM -0700, Greg KH wrote:
> On Mon, Oct 17, 2011 at 08:03:51PM +0200, Hans J. Koch wrote:
> > On Mon, Oct 17, 2011 at 07:18:59PM +0200, Hans J. Koch wrote:
> > > On Mon, Oct 17, 2011 at 11:00:55AM -0500, Kumar Gala wrote:
> > > > 
> > > > On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:
> > > > 
> > > > > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
> > > > >> From: Kai Jiang <Kai.Jiang@freescale.com>
> > > > >> 
> > > > >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > > > >> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > > > >> embedded PPC, ARM, and X86 have support for systems with larger physical
> > > > >> address than logical.
> > > > >> 
> > > > >> Since 'addr' may contain a physical, logical, or virtual address the
> > > > >> easiest solution is to just change the type to 'phys_addr_t' which
> > > > >> should always be greater than or equal to the sizeof(void *) such that
> > > > >> it can properly hold any of the address types.
> > > > >> 
> > > > >> For physical address we can support up to a 44-bit physical address on a
> > > > >> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> > > > >> the memory region and pfn's are represnted by shifting the address by
> > > > >> the page size (typically 4k).
> > > > >> 
> > > > >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> > > > >> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > > > >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > > > > 
> > > > > Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
> > > > > 
> > > > > That looks good to me. There's an unnecessary cast (see below), but I fixed that
> > > > > on the way.
> > > > > 
> > > > > Greg, please pull this from branch uio-for-gregkh from
> > > > > 
> > > > > git://hansjkoch.de/git/linux-hjk
> > > > > 
> > > > > Thanks,
> > > > > Hans
> > > > 
> > > > I think removing that cast is wrong:
> > > > 
> > > > drivers/uio/uio.c: In function 'uio_vma_fault':
> > > > drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size
> > > 
> > > Hmm, on what platform did you see this? I tested on 32bit-x86 and didn't get
> > > any warnings.
> > 
> > OK, you're right. I turned on CONFIG_HIGHMEM64G and got that warning. Damned x86...
> > 
> > Greg, can you fix it, or should I send the patch again?
> 
> Please send it again.

>From 30767223785a2ea412bd31a00a4534051af1f5dd Mon Sep 17 00:00:00 2001
From: Kai Jiang <Kai.Jiang@freescale.com>
Date: Fri, 14 Oct 2011 20:04:43 +0200
Subject: [PATCH] uio: Support physical addresses >32 bits on 32-bit systems

From: Kai Jiang <Kai.Jiang@freescale.com>

To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
extend the width of 'addr' in struct uio_mem.  Numerous platforms like
embedded PPC, ARM, and X86 have support for systems with larger physical
address than logical.

Since 'addr' may contain a physical, logical, or virtual address the
easiest solution is to just change the type to 'phys_addr_t' which
should always be greater than or equal to the sizeof(void *) such that
it can properly hold any of the address types.

For physical address we can support up to a 44-bit physical address on a
typical 32-bit system as we utilize remap_pfn_range() for the mapping of
the memory region and pfn's are represnted by shifting the address by
the page size (typically 4k).

Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Hans J. Koch <hjk@hansjkoch.de>
---
 Documentation/DocBook/uio-howto.tmpl |    2 +-
 drivers/uio/uio.c                    |    7 +++----
 include/linux/uio_driver.h           |    7 +++++--
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/Documentation/DocBook/uio-howto.tmpl b/Documentation/DocBook/uio-howto.tmpl
index 7c4b514d..54883de 100644
--- a/Documentation/DocBook/uio-howto.tmpl
+++ b/Documentation/DocBook/uio-howto.tmpl
@@ -529,7 +529,7 @@ memory (e.g. allocated with <function>kmalloc()</function>). There's also
 </para></listitem>
 
 <listitem><para>
-<varname>unsigned long addr</varname>: Required if the mapping is used.
+<varname>phys_addr_t addr</varname>: Required if the mapping is used.
 Fill in the address of your memory block. This address is the one that
 appears in sysfs.
 </para></listitem>
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index d2efe82..dc27d89 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr);
 }
 
 static ssize_t map_size_show(struct uio_mem *mem, char *buf)
@@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
+	return sprintf(buf, "0x%llx\n", (unsigned long long)mem->addr & ~PAGE_MASK);
 }
 
 struct map_sysfs_entry {
@@ -634,8 +634,7 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
 		page = virt_to_page(idev->info->mem[mi].addr + offset);
 	else
-		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
-							+ offset);
+		page = vmalloc_to_page((void *)(unsigned long)idev->info->mem[mi].addr + offset);
 	get_page(page);
 	vmf->page = page;
 	return 0;
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index 665517c..fd99ff9 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -23,7 +23,10 @@ struct uio_map;
 /**
  * struct uio_mem - description of a UIO memory region
  * @name:		name of the memory region for identification
- * @addr:		address of the device's memory
+ * @addr:		address of the device's memory (phys_addr is used since
+ * 			addr can be logical, virtual, or physical & phys_addr_t
+ * 			should always be large enough to handle any of the
+ * 			address types)
  * @size:		size of IO
  * @memtype:		type of memory addr points to
  * @internal_addr:	ioremap-ped version of addr, for driver internal use
@@ -31,7 +34,7 @@ struct uio_map;
  */
 struct uio_mem {
 	const char		*name;
-	unsigned long		addr;
+	phys_addr_t		addr;
 	unsigned long		size;
 	int			memtype;
 	void __iomem		*internal_addr;
-- 
1.7.6.3

[PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

From: Kai Jiang <Kai.Jiang@freescale.com>

To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
extend the width of 'addr' in struct uio_mem.  Numerous platforms like
embedded PPC, ARM, and X86 have support for systems with larger physical
address than logical.

Since 'addr' may contain a physical, logical, or virtual address the
easiest solution is to just change the type to 'unsigned long long'
regardless of which type is utilized.

For physical address we can support up to a 44-bit physical address on a
typical 32-bit system as we utilize remap_pfn_range() for the mapping of
the memory region and pfn's are represnted by shifting the address by
the page size (typically 4k).

Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 drivers/uio/uio.c          |    8 ++++----
 include/linux/uio_driver.h |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index d2efe82..a927c51 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr);
+	return sprintf(buf, "0x%llx\n", mem->addr);
 }
 
 static ssize_t map_size_show(struct uio_mem *mem, char *buf)
@@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
 
 static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
 {
-	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
+	return sprintf(buf, "0x%llx\n", mem->addr & ~PAGE_MASK);
 }
 
 struct map_sysfs_entry {
@@ -634,8 +634,8 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
 		page = virt_to_page(idev->info->mem[mi].addr + offset);
 	else
-		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
-							+ offset);
+		page = vmalloc_to_page((void *)(unsigned long)
+				idev->info->mem[mi].addr + offset);
 	get_page(page);
 	vmf->page = page;
 	return 0;
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index 665517c..c1fdb19 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -31,7 +31,7 @@ struct uio_map;
  */
 struct uio_mem {
 	const char		*name;
-	unsigned long		addr;
+	unsigned long long	addr;
 	unsigned long		size;
 	int			memtype;
 	void __iomem		*internal_addr;
-- 
1.7.3.4

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> From: Kai Jiang <Kai.Jiang@freescale.com>
> 
> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> embedded PPC, ARM, and X86 have support for systems with larger physical
> address than logical.
> 
> Since 'addr' may contain a physical, logical, or virtual address the
> easiest solution is to just change the type to 'unsigned long long'
> regardless of which type is utilized.

No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
Please use that.

Thanks,
Hans

> 
> For physical address we can support up to a 44-bit physical address on a
> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
> the memory region and pfn's are represnted by shifting the address by
> the page size (typically 4k).
> 
> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  drivers/uio/uio.c          |    8 ++++----
>  include/linux/uio_driver.h |    2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index d2efe82..a927c51 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, char *buf)
>  
>  static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
>  {
> -	return sprintf(buf, "0x%lx\n", mem->addr);
> +	return sprintf(buf, "0x%llx\n", mem->addr);
>  }
>  
>  static ssize_t map_size_show(struct uio_mem *mem, char *buf)
> @@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, char *buf)
>  
>  static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
>  {
> -	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
> +	return sprintf(buf, "0x%llx\n", mem->addr & ~PAGE_MASK);
>  }
>  
>  struct map_sysfs_entry {
> @@ -634,8 +634,8 @@ static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
>  	if (idev->info->mem[mi].memtype == UIO_MEM_LOGICAL)
>  		page = virt_to_page(idev->info->mem[mi].addr + offset);
>  	else
> -		page = vmalloc_to_page((void *)idev->info->mem[mi].addr
> -							+ offset);
> +		page = vmalloc_to_page((void *)(unsigned long)
> +				idev->info->mem[mi].addr + offset);
>  	get_page(page);
>  	vmf->page = page;
>  	return 0;
> diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
> index 665517c..c1fdb19 100644
> --- a/include/linux/uio_driver.h
> +++ b/include/linux/uio_driver.h
> @@ -31,7 +31,7 @@ struct uio_map;
>   */
>  struct uio_mem {
>  	const char		*name;
> -	unsigned long		addr;
> +	unsigned long long	addr;
>  	unsigned long		size;
>  	int			memtype;
>  	void __iomem		*internal_addr;
> -- 
> 1.7.3.4
> 
> 

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

On Oct 12, 2011, at 10:32 AM, Hans J. Koch wrote:

> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>=20
>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need =
to
>> extend the width of 'addr' in struct uio_mem.  Numerous platforms =
like
>> embedded PPC, ARM, and X86 have support for systems with larger =
physical
>> address than logical.
>>=20
>> Since 'addr' may contain a physical, logical, or virtual address the
>> easiest solution is to just change the type to 'unsigned long long'
>> regardless of which type is utilized.
>=20
> No. There's phys_addr_t for that purpose, defined in =
include/linux/types.h.
> Please use that.

Do we believe phys_addr_t is always greater than or equal to size need =
for logical & virtual addresses?

- k


> Thanks,
> Hans
>=20
>>=20
>> For physical address we can support up to a 44-bit physical address =
on a
>> typical 32-bit system as we utilize remap_pfn_range() for the mapping =
of
>> the memory region and pfn's are represnted by shifting the address by
>> the page size (typically 4k).
>>=20
>> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> drivers/uio/uio.c          |    8 ++++----
>> include/linux/uio_driver.h |    2 +-
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>=20
>> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
>> index d2efe82..a927c51 100644
>> --- a/drivers/uio/uio.c
>> +++ b/drivers/uio/uio.c
>> @@ -69,7 +69,7 @@ static ssize_t map_name_show(struct uio_mem *mem, =
char *buf)
>>=20
>> static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
>> {
>> -	return sprintf(buf, "0x%lx\n", mem->addr);
>> +	return sprintf(buf, "0x%llx\n", mem->addr);
>> }
>>=20
>> static ssize_t map_size_show(struct uio_mem *mem, char *buf)
>> @@ -79,7 +79,7 @@ static ssize_t map_size_show(struct uio_mem *mem, =
char *buf)
>>=20
>> static ssize_t map_offset_show(struct uio_mem *mem, char *buf)
>> {
>> -	return sprintf(buf, "0x%lx\n", mem->addr & ~PAGE_MASK);
>> +	return sprintf(buf, "0x%llx\n", mem->addr & ~PAGE_MASK);
>> }
>>=20
>> struct map_sysfs_entry {
>> @@ -634,8 +634,8 @@ static int uio_vma_fault(struct vm_area_struct =
*vma, struct vm_fault *vmf)
>> 	if (idev->info->mem[mi].memtype =3D=3D UIO_MEM_LOGICAL)
>> 		page =3D virt_to_page(idev->info->mem[mi].addr + =
offset);
>> 	else
>> -		page =3D vmalloc_to_page((void =
*)idev->info->mem[mi].addr
>> -							+ offset);
>> +		page =3D vmalloc_to_page((void *)(unsigned long)
>> +				idev->info->mem[mi].addr + offset);
>> 	get_page(page);
>> 	vmf->page =3D page;
>> 	return 0;
>> diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
>> index 665517c..c1fdb19 100644
>> --- a/include/linux/uio_driver.h
>> +++ b/include/linux/uio_driver.h
>> @@ -31,7 +31,7 @@ struct uio_map;
>>  */
>> struct uio_mem {
>> 	const char		*name;
>> -	unsigned long		addr;
>> +	unsigned long long	addr;
>> 	unsigned long		size;
>> 	int			memtype;
>> 	void __iomem		*internal_addr;
>> --=20
>> 1.7.3.4
>>=20
>>=20

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Geert Uytterhoeven]

On Wed, Oct 12, 2011 at 18:07, Kumar Gala <galak@kernel.crashing.org> wrote=
:
> On Oct 12, 2011, at 10:32 AM, Hans J. Koch wrote:
>> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
>>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>>
>>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
>>> extend the width of 'addr' in struct uio_mem. =C2=A0Numerous platforms =
like
>>> embedded PPC, ARM, and X86 have support for systems with larger physica=
l
>>> address than logical.
>>>
>>> Since 'addr' may contain a physical, logical, or virtual address the
>>> easiest solution is to just change the type to 'unsigned long long'
>>> regardless of which type is utilized.
>>
>> No. There's phys_addr_t for that purpose, defined in include/linux/types=
.h.
>> Please use that.
>
> Do we believe phys_addr_t is always greater than or equal to size need fo=
r logical & virtual addresses?

Yes:

#ifdef CONFIG_PHYS_ADDR_T_64BIT
typedef u64 phys_addr_t;
#else
typedef u32 phys_addr_t;
#endif

config PHYS_ADDR_T_64BIT
        def_bool 64BIT || ARCH_PHYS_ADDR_T_64BIT

Gr{oetje,eeting}s,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Tabi Timur-B04825]

On Wed, Oct 12, 2011 at 11:15 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
>> Do we believe phys_addr_t is always greater than or equal to size need f=
or logical & virtual addresses?
>
> Yes:
>
> #ifdef CONFIG_PHYS_ADDR_T_64BIT
> typedef u64 phys_addr_t;
> #else
> typedef u32 phys_addr_t;
> #endif

This isn't really an answer to the question.  This just says that
phys_addr_t can be 64-bit.  I don't see anywhere in the kernel that we
*enforce* or *require* that sizeof(phys_addr_t) >=3D sizeof(void *).

--=20
Timur Tabi
Linux kernel developer at Freescale=

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Geert Uytterhoeven]

On Thu, Oct 13, 2011 at 16:10, Tabi Timur-B04825 <B04825@freescale.com> wro=
te:
> On Wed, Oct 12, 2011 at 11:15 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>>
>>> Do we believe phys_addr_t is always greater than or equal to size need =
for logical & virtual addresses?
>>
>> Yes:
>>
>> #ifdef CONFIG_PHYS_ADDR_T_64BIT
>> typedef u64 phys_addr_t;
>> #else
>> typedef u32 phys_addr_t;
>> #endif
>
> This isn't really an answer to the question. =C2=A0This just says that
> phys_addr_t can be 64-bit. =C2=A0I don't see anywhere in the kernel that =
we
> *enforce* or *require* that sizeof(phys_addr_t) >=3D sizeof(void *).

You deleted this part:

config PHYS_ADDR_T_64BIT
       def_bool 64BIT || ARCH_PHYS_ADDR_T_64BIT

which enforces that PHYS_ADDR_T_64BIT is enabled if 64BIT is set.

It still doesn't protect against 64-bit architectures not setting 64BIT,
but they have worse problems ;-)

On 32-bit platforms, void * is 32-bit, and phys_addr_t is either
32-bit or 64-bit.
On 64-bit platforms (which are required to set 64BIT), void * is 64-bit,
just like phys_addr_t.

Gr{oetje,eeting}s,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Timur Tabi]

Geert Uytterhoeven wrote:

> You deleted this part:
> 
> config PHYS_ADDR_T_64BIT
>        def_bool 64BIT || ARCH_PHYS_ADDR_T_64BIT
> 
> which enforces that PHYS_ADDR_T_64BIT is enabled if 64BIT is set.

Ok, I didn't catch that before, but it makes sense now.  Thanks.

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Wed, Oct 12, 2011 at 11:07:09AM -0500, Kumar Gala wrote:
> 
> On Oct 12, 2011, at 10:32 AM, Hans J. Koch wrote:
> 
> > On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> >> From: Kai Jiang <Kai.Jiang@freescale.com>
> >> 
> >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> >> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> >> embedded PPC, ARM, and X86 have support for systems with larger physical
> >> address than logical.
> >> 
> >> Since 'addr' may contain a physical, logical, or virtual address the
> >> easiest solution is to just change the type to 'unsigned long long'
> >> regardless of which type is utilized.
> > 
> > No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
> > Please use that.
> 
> Do we believe phys_addr_t is always greater than or equal to size need for logical & virtual addresses?

Yes.

Hans

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> > From: Kai Jiang <Kai.Jiang@freescale.com>
> > 
> > To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > embedded PPC, ARM, and X86 have support for systems with larger physical
> > address than logical.
> > 
> > Since 'addr' may contain a physical, logical, or virtual address the
> > easiest solution is to just change the type to 'unsigned long long'
> > regardless of which type is utilized.
> 
> No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
> Please use that.

I forgot: If you resend this, please update the documentation as well.
(Documentation/DocBook/uio-howto.tmpl)

Thanks,
Hans

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

On Oct 12, 2011, at 11:19 AM, Hans J. Koch wrote:

> On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
>> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
>>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>>=20
>>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need =
to
>>> extend the width of 'addr' in struct uio_mem.  Numerous platforms =
like
>>> embedded PPC, ARM, and X86 have support for systems with larger =
physical
>>> address than logical.
>>>=20
>>> Since 'addr' may contain a physical, logical, or virtual address the
>>> easiest solution is to just change the type to 'unsigned long long'
>>> regardless of which type is utilized.
>>=20
>> No. There's phys_addr_t for that purpose, defined in =
include/linux/types.h.
>> Please use that.
>=20
> I forgot: If you resend this, please update the documentation as well.
> (Documentation/DocBook/uio-howto.tmpl)

What would you look added or modified here?

- k=

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Hans J. Koch]

On Wed, Oct 12, 2011 at 01:40:22PM -0500, Kumar Gala wrote:
> 
> On Oct 12, 2011, at 11:19 AM, Hans J. Koch wrote:
> 
> > On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
> >> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> >>> From: Kai Jiang <Kai.Jiang@freescale.com>
> >>> 
> >>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> >>> extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> >>> embedded PPC, ARM, and X86 have support for systems with larger physical
> >>> address than logical.
> >>> 
> >>> Since 'addr' may contain a physical, logical, or virtual address the
> >>> easiest solution is to just change the type to 'unsigned long long'
> >>> regardless of which type is utilized.
> >> 
> >> No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
> >> Please use that.
> > 
> > I forgot: If you resend this, please update the documentation as well.
> > (Documentation/DocBook/uio-howto.tmpl)
> 
> What would you look added or modified here?

struct uio_mem ?

Hans

> 
> - k

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

[Kumar Gala]

On Oct 12, 2011, at 3:23 PM, Hans J. Koch wrote:

> On Wed, Oct 12, 2011 at 01:40:22PM -0500, Kumar Gala wrote:
>>=20
>> On Oct 12, 2011, at 11:19 AM, Hans J. Koch wrote:
>>=20
>>> On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
>>>> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
>>>>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>>>>=20
>>>>> To support >32-bit physical addresses for UIO_MEM_PHYS type we =
need to
>>>>> extend the width of 'addr' in struct uio_mem.  Numerous platforms =
like
>>>>> embedded PPC, ARM, and X86 have support for systems with larger =
physical
>>>>> address than logical.
>>>>>=20
>>>>> Since 'addr' may contain a physical, logical, or virtual address =
the
>>>>> easiest solution is to just change the type to 'unsigned long =
long'
>>>>> regardless of which type is utilized.
>>>>=20
>>>> No. There's phys_addr_t for that purpose, defined in =
include/linux/types.h.
>>>> Please use that.
>>>=20
>>> I forgot: If you resend this, please update the documentation as =
well.
>>> (Documentation/DocBook/uio-howto.tmpl)
>>=20
>> What would you look added or modified here?
>=20
> struct uio_mem ?
>=20
> Hans

New version sent, let me know if there are any other aspects to the =
DocBook that need updating.

- k=