From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f43.google.com (mail-pz0-f43.google.com [209.85.210.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 7CC851007D1 for ; Sat, 22 Oct 2011 04:32:52 +1100 (EST) Received: by pzk33 with SMTP id 33so10276248pzk.2 for ; Fri, 21 Oct 2011 10:32:50 -0700 (PDT) Date: Fri, 21 Oct 2011 10:33:02 -0700 From: Olof Johansson To: tmarri@apm.com Subject: Re: [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver Message-ID: <20111021173302.GB27652@quad.lixom.net> References: <1318630114-14064-1-git-send-email-tmarri@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1318630114-14064-1-git-send-email-tmarri@apm.com> Cc: greg@kroah.com, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 14, 2011 at 03:08:34PM -0700, tmarri@apm.com wrote: > From: Tirumala Marri Overall this driver seems to be based on the IP vendor driver? It looks like a completely flexible driver that implements all possible combinations of everything. And as a result, it's huge, and it's got a lot of extra code in there that I'm willing to bet that you have never even executed on your platform. Please, pare it down to the portions that you have used, and know works and can support. If others need the extra functionality in the future, they can and will expand and bring in what is needed. Compare this to the dwc3 driver, which is much much cleaner. Overall other comments: * Register definitions are crazy long. It means you have to do lots of line wraps to keep the 80-character limit, which makes it hard to read the code. * The header files seem to have been autogenerated and have unnneeded shift/mask operations. * It doesn't build on non-powerpc platforms since it uses out_{b,l}e accessors. -Olof