From: David Gibson <david@gibson.dropbear.id.au>
To: Robert Sciuk <robert.sciuk@exfo.com>
Cc: linuxppc-dev@lists.ozlabs.org,
devicetree-discuss@lists.ozlabs.org,
Tabi Timur-B04825 <B04825@freescale.com>
Subject: Re: fpga driver on custom PPC target platform (P4080) ...
Date: Sat, 5 Nov 2011 11:40:50 +1100 [thread overview]
Message-ID: <20111105004050.GA1384@truffala.fritz.box> (raw)
In-Reply-To: <2DD52030B5146141BEB762A11AE97C4C0100C8C1@SPQCEXC05.exfo.com>
On Fri, Nov 04, 2011 at 02:19:36PM -0400, Robert Sciuk wrote:
> > >
> > > I *believe* you are not supposed to create separate nodes for reading
> > > and writing. I know that's how I2C works, but I think the I2C layer
> > > takes care of that for you.
> > >
> > > If you look at other device trees, you'll see they only have one node
> > > for any particular I2C device.
> > >
> >
> >
> > Thanks, Timur ... I've fixed the tree, and I'm tracking down the
> > problems with addressing the nodes ...
>
> Ah, my compatible attribute was wrong:
>
> Compatible = "nxp,pca9539";
>
> Should have been:
>
> Compatible = "nxp,pca953x";
>
> The tree now seems to bind the i2c gpio drivers properly ... on to
> the localbus mappings!
Ah. In that case the drivers should probably be extended to recognize
the first compatible. "wildcard" compatible strings are a bad idea,
unfortunately there are some already in the wild, as you've seen. We
should try to phase them out though.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-11-05 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 22:12 fpga driver on custom PPC target platform (P4080) Robert Sciuk
2011-11-04 16:36 ` Tabi Timur-B04825
2011-11-04 16:42 ` Robert Sciuk
2011-11-04 18:19 ` Robert Sciuk
2011-11-05 0:40 ` David Gibson [this message]
2011-11-07 18:48 ` Robert Sciuk
2011-11-07 20:09 ` Robert Sciuk
2011-11-07 21:31 ` Mitch Bradley
2011-11-07 21:50 ` Robert Sciuk
2011-11-07 22:14 ` Scott Wood
2011-11-07 23:07 ` Robert Sciuk
2011-11-07 23:29 ` Robert Sciuk
-- strict thread matches above, loose matches on Subject: below --
2011-11-02 22:43 Robert Sciuk
2011-11-03 21:22 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111105004050.GA1384@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=B04825@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robert.sciuk@exfo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).