From: Greg KH <gregkh@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
miche@google.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Linus <torvalds@linux-foundation.org>
Subject: Re: Regression: patch " hvc_console: display printk messages on console." causing infinite loop with 3.2-rc0 + Xen.
Date: Mon, 7 Nov 2011 12:24:51 -0800 [thread overview]
Message-ID: <20111107202451.GA14482@suse.de> (raw)
In-Reply-To: <20111107171942.fe21429583491475f245aa08@canb.auug.org.au>
On Mon, Nov 07, 2011 at 05:19:42PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> On Wed, 2 Nov 2011 18:30:12 -0700 Greg KH <gregkh@suse.de> wrote:
> >
> > On Wed, Nov 02, 2011 at 12:13:09PM +1100, Stephen Rothwell wrote:
> > >
> > > On Thu, 27 Oct 2011 07:48:06 +0200 Greg KH <gregkh@suse.de> wrote:
> > > >
> > > > On Thu, Oct 27, 2011 at 01:30:08AM -0400, Konrad Rzeszutek Wilk wrote:
> > > > > Hey Miche.
> > > > >
> > > > > The git commit 361162459f62dc0826b82c9690a741a940f457f0:
> > > > >
> > > > > hvc_console: display printk messages on console.
> > > > >
> > > > > is causing an infinite loop when booting Linux under Xen, as so:
> > > >
> > > > Ick, not good, thanks for letting us know.
> > >
> > > Indeed. I am wondering why it was put in a tree and sent to Linus without
> > > any Acks or even being replied to by anyone. It appeared in the tty tree
> > > between Oct 14 and Oct 25 (while I was unfortunately on vacation). If
> > > anyone had tried to boot this on any PowerPC server, it would have been
> > > immediately obvious (as it was when I booted Linus' tree last night).
> > >
> > > And the original author expressed doubts as to his understanding of how
> > > it should all work anyway.
> > >
> > > Just a little more care, please.
> > >
> > > I would vote for reverting the original and having it resubmitted with
> > > corrections at some later date.
> >
> > You are right, I will go do that, sorry for the problems.
>
> Ping ...
>
> Linus can you please just revert 361162459f62dc0826b82c9690a741a940f457f0
> "hvc_console: display printk messages on console" as it breaks consoles
> for all PowerPC server machines.
Thanks for doing this, I was going to include it in my next pull request
after 3.2-rc1 was out, but you are right, it should have gone in sooner.
greg k-h
prev parent reply other threads:[~2011-11-07 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111027053007.GA32765@phenom.dumpdata.com>
[not found] ` <20111027054806.GA1377@suse.de>
2011-11-02 1:13 ` Regression: patch " hvc_console: display printk messages on console." causing infinite loop with 3.2-rc0 + Xen Stephen Rothwell
2011-11-03 1:30 ` Greg KH
2011-11-07 6:19 ` Stephen Rothwell
2011-11-07 20:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107202451.GA14482@suse.de \
--to=gregkh@suse.de \
--cc=amit.shah@redhat.com \
--cc=anton@samba.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miche@google.com \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).