linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][PATCH 28/30] powerpc/85xx: Rework P1023RDS device tree
Date: Thu, 10 Nov 2011 12:55:59 -0600	[thread overview]
Message-ID: <20111110185559.GA12339@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <B48BB824-D8FF-4D60-B0A5-B6C237074907@kernel.crashing.org>

On Thu, Nov 10, 2011 at 12:42:54PM -0600, Kumar Gala wrote:
> 
> On Nov 10, 2011, at 12:10 PM, Scott Wood wrote:
> 
> > On Thu, Nov 10, 2011 at 10:14:11AM -0600, Kumar Gala wrote:
> >> -		power@e0070{
> >> -			compatible = "fsl,mpc8536-pmc", "fsl,mpc8548-pmc",
> >> -			             "fsl,p1022-pmc";
> >> -			reg = <0xe0070 0x20>;
> >> -			etsec1_clk: soc-clk@B0{
> >> -				fsl,pmcdr-mask = <0x00000080>;
> >> -			};
> >> -			etsec2_clk: soc-clk@B1{
> >> -				fsl,pmcdr-mask = <0x00000040>;
> >> -			};
> >> -			etsec3_clk: soc-clk@B2{
> >> -				fsl,pmcdr-mask = <0x00000020>;
> >> -			};
> >> -		};
> > 
> > The compatibles on this node are wrong, but it looks like you're removing
> > it altogether?
> > 
> > -Scott
> 
> Yeah, I think the whole thing needs to be relocated at because there are no etsec's on P1023, etc.  So will comment about this in commit message

Ah right, the etsec stuff should go as well. :-)

It should look like this:

	power@e0070 {
		compatible = "fsl,p1023-pmc", "fsl,mpc8548-pmc";
		reg = <0xe0070 0x20>;
	};

-Scott

  reply	other threads:[~2011-11-10 18:56 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 16:13 [RFC][PATCH 00/30] Rework FSL MPC85xx/Pxxxx device trees Kumar Gala
2011-11-10 16:13 ` [RFC][PATCH 01/30] powerpc/85xx: Simplify P1020RDB CAMP dts using includes Kumar Gala
2011-11-10 16:13   ` [RFC][PATCH 02/30] powerpc/85xx: Rework PCI nodes on P1020RDB Kumar Gala
2011-11-10 16:13     ` [RFC][PATCH 03/30] powerpc/85xx: Update SPI binding to match binding spec for P1020RDB Kumar Gala
2011-11-10 16:13       ` [RFC][PATCH 04/30] powerpc/85xx: Update P1020 SEC3.3 node to match actual SoC HW Kumar Gala
2011-11-10 16:13         ` [RFC][PATCH 05/30] powerpc/85xx: Add ethernet magic packet property to P1020 device tree Kumar Gala
2011-11-10 16:13           ` [RFC][PATCH 06/30] powerpc/85xx: p1020si.dtsi update interrupt handling Kumar Gala
2011-11-10 16:13             ` [RFC][PATCH 07/30] powerpc/85xx: create dts components to build up an SoC Kumar Gala
2011-11-10 16:13               ` [RFC][PATCH 08/30] powerpc/85xx: Rework P1020 SoC device tree Kumar Gala
2011-11-10 16:13                 ` [RFC][PATCH 09/30] powerpc/85xx: Rework P1020RDB " Kumar Gala
2011-11-10 16:13                   ` [RFC][PATCH 10/30] powerpc/85xx: Add P1020RDB 36-bit address map " Kumar Gala
2011-11-10 16:13                     ` [RFC][PATCH 11/30] powerpc/85xx: Rework P1010RDB and P1010 " Kumar Gala
2011-11-10 16:13                       ` [RFC][PATCH 12/30] powerpc/85xx: Add RTC to P1010RDB " Kumar Gala
2011-11-10 16:13                         ` [RFC][PATCH 13/30] powerpc/85xx: Add crypto engine to P1010 SoC " Kumar Gala
2011-11-10 16:13                           ` [RFC][PATCH 14/30] powerpc/85xx: Add a P1010RDB 36-bit address map " Kumar Gala
2011-11-10 16:13                             ` [RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS " Kumar Gala
2011-11-10 16:13                               ` [RFC][PATCH 16/30] powerpc/85xx: Rework P2020DS " Kumar Gala
2011-11-10 16:14                                 ` [RFC][PATCH 17/30] powerpc/85xx: Rework P2020RDB " Kumar Gala
2011-11-10 16:14                                   ` [RFC][PATCH 18/30] powerpc/85xx: Rework P1021MDS " Kumar Gala
2011-11-10 16:14                                     ` [RFC][PATCH 19/30] powerpc/85xx: Rework MPC8572DS " Kumar Gala
2011-11-10 16:14                                       ` [RFC][PATCH 20/30] powerpc/85xx: Rework MPC8536DS device trees Kumar Gala
2011-11-10 16:14                                         ` [RFC][PATCH 21/30] powerpc/85xx: Rework MPC8544DS device tree Kumar Gala
2011-11-10 16:14                                           ` [RFC][PATCH 22/30] powerpc/85xx: Rework MPC8548CDS device trees Kumar Gala
2011-11-10 16:14                                             ` [RFC][PATCH 23/30] powerpc/85xx: Rework P4080DS " Kumar Gala
2011-11-10 16:14                                               ` [RFC][PATCH 24/30] powerpc/85xx: Rework P5020DS device tree Kumar Gala
2011-11-10 16:14                                                 ` [RFC][PATCH 25/30] powerpc/85xx: Rework P3041DS " Kumar Gala
2011-11-10 16:14                                                   ` [RFC][PATCH 26/30] powerpc/85xx: Rework P2041RDB " Kumar Gala
2011-11-10 16:14                                                     ` [RFC][PATCH 27/30] powerpc/85xx: Rework P3060QDS " Kumar Gala
2011-11-10 16:14                                                       ` [RFC][PATCH 28/30] powerpc/85xx: Rework P1023RDS " Kumar Gala
2011-11-10 16:14                                                         ` [RFC][PATCH 29/30] powerpc/85xx: Rework MPC8568MDS " Kumar Gala
2011-11-10 16:14                                                           ` [RFC][PATCH 30/30] powerpc/85xx: Rework MPC8569MDS " Kumar Gala
2011-11-10 18:10                                                         ` [RFC][PATCH 28/30] powerpc/85xx: Rework P1023RDS " Scott Wood
2011-11-10 18:42                                                           ` Kumar Gala
2011-11-10 18:55                                                             ` Scott Wood [this message]
2011-11-10 20:24                                                               ` Kumar Gala
2011-11-10 17:30                               ` [RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS " Tabi Timur-B04825
2011-11-10 18:50                                 ` Kumar Gala
2011-11-15 23:49                               ` Tabi Timur-B04825
2011-11-16 21:47                                 ` Timur Tabi
2011-11-16 21:50                                   ` Kumar Gala
2011-11-10 18:05                 ` [RFC][PATCH 08/30] powerpc/85xx: Rework P1020 SoC " Scott Wood
2011-11-10 18:46                   ` Kumar Gala
2011-11-10 18:58                     ` Scott Wood
2011-11-10 20:27                       ` Kumar Gala
2011-11-11 15:29                         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111110185559.GA12339@schlenkerla.am.freescale.net \
    --to=scottwood@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).