From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tango.tkos.co.il (tango.tkos.co.il [62.219.50.35]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 71BC0B6F83 for ; Tue, 15 Nov 2011 16:17:31 +1100 (EST) Date: Tue, 15 Nov 2011 07:17:14 +0200 From: Baruch Siach To: Fleming Andy-AFLEMING Subject: Re: [PATCH] net: fsl_pq_mdio: fix non tbi phy access Message-ID: <20111115051713.GA4052@sapphire.tkos.co.il> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: "netdev@vger.kernel.org" , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Andy, On Mon, Nov 14, 2011 at 09:04:47PM +0000, Fleming Andy-AFLEMING wrote: > Well, this got applied quickly, so I guess I can't NAK, but this requires discussion. > > On Nov 14, 2011, at 0:22, "Baruch Siach" wrote: > > > Since 952c5ca1 (fsl_pq_mdio: Clean up tbi address configuration) .probe returns > > -EBUSY when the "tbi-phy" node is missing. Fix this. > > It returns an error because it finds no tbi node. Because without the tbi > node, there is no way for the driver to determine which address to set. > > Your solution is to ignore the error, and hope. That's a broken approach. > The real solution for a p1010 should be to have a tbi node in the dts. Can you elaborate a bit on why this approach is broken? The PHY used to work for me until 952c5ca1, and with this applied. > And looking at the p1010si.dtsi, I see that it's automatically there for > you. > > How were you breaking? Adding linuxppc to Cc. My board is P1011 based, the single core version of P1020, not P1010. In p1020si.dtsi I see no tbi node. In p1020rdb.dts I see a tbi node but only for mdio@25000, not mdio@24000, which is what I'm using. Am I missing something? baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -