From: Felipe Balbi <balbi@ti.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org, balbi@ti.com,
Peter Chen <peter.chen@freescale.com>,
linuxppc-dev@lists.ozlabs.org, stable@kernel.org
Subject: Re: [PATCH] USB: fsl_udc_core: Use (&) instead of (==) to compare ISO XFER
Date: Thu, 24 Nov 2011 11:37:47 +0200 [thread overview]
Message-ID: <20111124093746.GK3352@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <op.v5bqaaw33l0zgt@mpn-glaptop>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Tue, Nov 22, 2011 at 02:26:24AM +0100, Michal Nazarewicz wrote:
> >On Tue, 22 Nov 2011 02:15:21 +0100, Peter Chen <peter.chen@freescale.com> wrote:
> >>@@ -877,7 +877,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
> >> VDBG("%s, bad ep", __func__);
> >> return -EINVAL;
> >> }
> >>- if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) {
> >>+ if (ep->desc->bmAttributes & USB_ENDPOINT_XFER_ISOC) {
>
> On Tue, 22 Nov 2011 02:22:10 +0100, Michal Nazarewicz <mina86@mina86.com> wrote:
> >What you really meant is:
> >
> >(ep->desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_ISOC
> >
> >It would probably be useful to create a function that performs that check rather
> >than having to type all of that every time.
>
> Ah, there it is:
>
> usb_endpoint_xfer_isoc(ep)
yeah, please use the helpers.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-24 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 1:15 [PATCH] USB: fsl_udc_core: Use (&) instead of (==) to compare ISO XFER Peter Chen
2011-11-22 1:22 ` Michal Nazarewicz
2011-11-22 1:26 ` Michal Nazarewicz
2011-11-24 9:37 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124093746.GK3352@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mina86@mina86.com \
--cc=peter.chen@freescale.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).