From: Anatolij Gustschin <agust@denx.de>
To: acrux <acrux_it@libero.it>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: sam460ex, sm501 incorrect device id with kernel >=linux-2.6.39
Date: Fri, 2 Dec 2011 16:35:18 +0100 [thread overview]
Message-ID: <20111202163518.7d7f0a74@wker> (raw)
In-Reply-To: <20111202154833.72c75615.acrux_it@libero.it>
Hi,
On Fri, 2 Dec 2011 15:48:33 +0100
acrux <acrux_it@libero.it> wrote:
...
> This little hack fix my problem:
> --- a/inlcude/linux/sm501.h 2011-12-02 01:11:04.000000000 +0100
> +++ b/include/linux/sm501.h 2011-12-02 01:11:09.000000000 +0100
> @@ -174,8 +174,8 @@
> };
>
> #if defined(CONFIG_PPC32)
> -#define smc501_readl(addr) ioread32be((addr))
> -#define smc501_writel(val, addr) iowrite32be((val), (addr))
> +#define smc501_readl(addr) ioread32((addr))
> +#define smc501_writel(val, addr) iowrite32((val), (addr))
> #else
> #define smc501_readl(addr) readl(addr)
> #define smc501_writel(val, addr) writel(val, addr)
>
>
> but instead, why am I obliged to read it as little endian to have the correct value?
The SM502 registers are in little endian format, you access them
over PCI interface, that is the reason. The commit introduced
a regression, I'll try to fix it this weekend. IIRC, there is
a flag to switch to big-endian register format in SM502, but
I'm not sure if it will also affect frame buffer data format.
Anatolij
next prev parent reply other threads:[~2011-12-02 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 16:37 sam460ex, sm501 incorrect device id with kernel >=linux-2.6.39 acrux
2011-11-28 12:12 ` Josh Boyer
2011-11-28 19:56 ` acrux
2011-11-28 20:22 ` Anatolij Gustschin
2011-12-02 14:48 ` acrux
2011-12-02 15:35 ` Anatolij Gustschin [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-29 1:00 acrux_it
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202163518.7d7f0a74@wker \
--to=agust@denx.de \
--cc=acrux_it@libero.it \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).