From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 16 Jan 2012 12:57:10 +1100 From: David Gibson To: Marek Szyprowski Subject: Re: [PATCH 01/14] common: dma-mapping: introduce alloc_attrs and free_attrs methods Message-ID: <20120116015710.GD4512@truffala.fritz.box> References: <1324643253-3024-1-git-send-email-m.szyprowski@samsung.com> <1324643253-3024-2-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1324643253-3024-2-git-send-email-m.szyprowski@samsung.com> Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Stephen Rothwell , Jonathan Corbet , x86@kernel.org, Arnd Bergmann , microblaze-uclinux@itee.uq.edu.au, linaro-mm-sig@lists.linaro.org, Andrzej Pietrasiewicz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, discuss@x86-64.org, linux-kernel@vger.kernel.org, Kyungmin Park , linux-alpha@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Dec 23, 2011 at 01:27:20PM +0100, Marek Szyprowski wrote: > Introduce new generic alloc and free methods with attributes argument. > > Existing alloc_coherent and free_coherent can be implemented on top of the > new calls with NULL attributes argument. Later also dma_alloc_non_coherent > can be implemented using DMA_ATTR_NONCOHERENT attribute as well as > dma_alloc_writecombine with separate DMA_ATTR_WRITECOMBINE attribute. > > This way the drivers will get more generic, platform independent way of > allocating dma buffers with specific parameters. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park Looks sensible to me. Reviewed-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson