From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
ben@decadent.org.uk
Subject: Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
Date: Wed, 1 Feb 2012 15:15:50 -0800 [thread overview]
Message-ID: <20120201231550.GO2382@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F29A072.9050203@windriver.com>
On Wed, Feb 01, 2012 at 03:28:34PM -0500, Paul Gortmaker wrote:
> On 12-02-01 01:55 PM, Paul E. McKenney wrote:
> > The variable cpus_in_crash gets a defined-but-not-used warning when
> > CONFIG_SMP=n, so fix by placing the variable under ifdef.
>
> I think Ben already merged a similar fix.
>
> http://patchwork.ozlabs.org/patch/136549/
>
> P.
Linus's tree does now have cpus_in_crash, so agreed. Sorry for the
noise!
Thanx, Paul
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> > index 28be345..eb3384e 100644
> > --- a/arch/powerpc/kernel/crash.c
> > +++ b/arch/powerpc/kernel/crash.c
> > @@ -46,7 +46,9 @@
> >
> > /* This keeps a track of which one is the crashing cpu. */
> > int crashing_cpu = -1;
> > +#ifdef CONFIG_SMP
> > static atomic_t cpus_in_crash;
> > +#endif /* #ifdef CONFIG_SMP */
> > static int time_to_dump;
> >
> > #define CRASH_HANDLER_MAX 3
> >
>
prev parent reply other threads:[~2012-02-01 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 18:55 [PATCH] powerpc: Define cpus_in_crash only for SMP kernels Paul E. McKenney
2012-02-01 20:28 ` Paul Gortmaker
2012-02-01 23:15 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201231550.GO2382@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).